public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sohil Mehta <sohil.mehta@intel.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	linux-pm@vger.kernel.org
Cc: x86@kernel.org, Tony Luck <tony.luck@intel.com>,
	Zhao Liu <zhao1.liu@linux.intel.com>,
	linux-kernel@vger.kernel.org, Sohil Mehta <sohil.mehta@intel.com>
Subject: [PATCH v3] cpufreq: ondemand: Update the efficient idle check for Intel extended Families
Date: Tue, 26 Aug 2025 11:36:44 -0700	[thread overview]
Message-ID: <20250826183644.220093-1-sohil.mehta@intel.com> (raw)

IO time is considered busy by default for modern Intel processors. The
current check covers recent Family 6 models but excludes the brand new
Families 18 and 19.

According to Arjan van de Ven, the model check was mainly due to a lack
of testing on systems before INTEL_CORE2_MEROM. He suggests considering
all Intel processors as having an efficient idle.

Extend the IO busy classification to all Intel processors starting with
Family 6, including Family 15 (Pentium 4s) and upcoming Families 18/19.

Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
---
v3:
 - Posting this patch separately since the core family cleanup series
   was merged without it.
 - Improve commit message and code comments.

v2: https://lore.kernel.org/lkml/20250211194407.2577252-7-sohil.mehta@intel.com/
---
 drivers/cpufreq/cpufreq_ondemand.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 0e65d37c9231..3decfc53fe68 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -15,6 +15,10 @@
 #include <linux/tick.h>
 #include <linux/sched/cpufreq.h>
 
+#ifdef CONFIG_X86
+#include <asm/cpu_device_id.h>
+#endif
+
 #include "cpufreq_ondemand.h"
 
 /* On-demand governor macros */
@@ -41,12 +45,9 @@ static unsigned int default_powersave_bias;
 static int should_io_be_busy(void)
 {
 #if defined(CONFIG_X86)
-	/*
-	 * For Intel, Core 2 (model 15) and later have an efficient idle.
-	 */
+	/* For Intel, Family 6 and later have an efficient idle. */
 	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL &&
-			boot_cpu_data.x86 == 6 &&
-			boot_cpu_data.x86_model >= 15)
+	    boot_cpu_data.x86_vfm >= INTEL_PENTIUM_PRO)
 		return 1;
 #endif
 	return 0;
-- 
2.43.0


             reply	other threads:[~2025-08-26 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 18:36 Sohil Mehta [this message]
2025-09-04 20:02 ` [PATCH v3] cpufreq: ondemand: Update the efficient idle check for Intel extended Families Rafael J. Wysocki
2025-09-05 21:32   ` Sohil Mehta
2025-09-08 18:54     ` Rafael J. Wysocki
2025-09-08 19:02       ` Sohil Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250826183644.220093-1-sohil.mehta@intel.com \
    --to=sohil.mehta@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=viresh.kumar@linaro.org \
    --cc=x86@kernel.org \
    --cc=zhao1.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox