Re: [PATCH v6 09/11] PCI: Put PCIe bridges with downstream devices into D3 at hibernate

Mario Limonciello (kernel.org)
2025-09-08T21:52:37Z

On 9/8/2025 4:50 PM, Bjorn Helgaas wrote:
> On Sun, Aug 17, 2025 at 09:00:59PM -0500, Mario Limonciello (AMD) wrote:
>> For the suspend flow PCIe bridges that have downstream devices are put into
>> the appropriate low power state (D3hot or D3cold depending upon specific
>> devices). For the hibernate flow, PCIe bridges with downstream devices
>> stay in D0 however. This can lead to PCIe bridges that are remained
>> powered on needlessly during hibernate.
>
> s/are remained/remain/ I guess?

Yeah, I'll adjust.

>
>> Adjust the pci_pm_poweroff_noirq() to follow the same flow as
>> pci_pm_suspend_noirq() by using pci_pm_suspend_noirq_common().
>>
>> This introduces a functional change that the hibernate flow will now
>> call pci_save_state() and unless bus PM is skipped will also set
>> the PCIe device into an unknown state.