Re: [PATCH v2 1/2] rust: clk: implement Send and Sync

Daniel Almeida
2025-09-10T18:48:05Z

Hi Boqun,

> On 10 Sep 2025, at 14:49, Boqun Feng <boqun.feng@gmail.com> wrote:
>
> On Wed, Sep 10, 2025 at 02:28:27PM -0300, Daniel Almeida wrote:
>> From: Alice Ryhl <aliceryhl@google.com>
>>
>> These traits are required for drivers to embed the Clk type in their own
>> data structures because driver data structures are usually required to
>> be Send. See e.g. [1] for the kind of workaround that drivers currently
>> need due to lacking this annotation.
>>
>> Link: https://lore.kernel.org/rust-for-linux/20250812-tyr-v2-1-9e0f3dc9da95@collabora.com/ [1]
>> Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
>> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>> Reviewed-by: Danilo Krummrich <dakr@kernel.org>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>> Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
>
> This tag list looks a bit weird to me. Why is there a SoB from you
> before Alice's SoB? At least for the usage I'm familiar with, outside
> the case of Co-developed-bys, multiple SoBs is used for recording how
> the patches are routed. For example, if I have a patch that has my SoB
> and I send it to you, you queue in your tree and then send out to other
> maintainers for merging, in general you would put your SoB after mine in
> that case. But I don't think that's case here? Alice's patch has only
> her SoB:
>
> https://lore.kernel.org/rust-for-linux/20250904-clk-send-sync-v1-1-48d023320eb8@google.com/
>
> What's the intention of the SoB tag here?
>
> Otherwise the patch looks good to me. If we get the tag list resolved,
> feel free to add:
>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
>
> Regards,
> Boqun
>

You have to include your SOB when submitting patches from others.

This is something I tend to forget often, so I made sure it was there. The
order may be indeed off though.

— Daniel