Re: [PATCH v2 1/4] dt-bindings: clock: mediatek: Add MT8189 clock definitions

Krzysztof Kozlowski
2025-09-14T12:04:03Z

On 12/09/2025 14:04, irving.ch.lin wrote:
> From: Irving-ch Lin <irving-ch.lin@mediatek.com>
>
> Add device tree bindings for the clock of MediaTek MT8189 SoC.
> These definitions will be used to describe the clock topology in
> device tree sources.

Drop last sentence, completely redundant. It cannot be anything else...

>
> Signed-off-by: Irving-ch Lin <irving-ch.lin@mediatek.com>
> ---

That's a v2, so where is any changelog? Nothing here nor in cover
letter. No changes, so you did not fix any of the bugs you had last time?

Why aren't you using b4 to submit patches which would handle this? If
you prefer to use older method, then fine but do it right.

> .../bindings/clock/mediatek,mt8189-clock.yaml | 89 +++
> .../clock/mediatek,mt8189-sys-clock.yaml | 58 ++
> .../dt-bindings/clock/mediatek,mt8189-clk.h | 580 ++++++++++++++++++
> 3 files changed, 727 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8189-clock.yaml
> create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8189-sys-clock.yaml
> create mode 100644 include/dt-bindings/clock/mediatek,mt8189-clk.h
>
Best regards,
Krzysztof