RE: [PATCH v3 1/3] dt-bindings: thermal: samsung: Add a hw-sensor-indices property

손신
2025-09-15T08:51:42Z

Hello, Krzysztof Kozlowski.

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk@kernel.org]
> Sent: Monday, September 15, 2025 1:29 PM
> To: Shin Son <shin.son@samsung.com>; Bartlomiej Zolnierkiewicz
> <bzolnier@gmail.com>; Rafael J . Wysocki <rafael@kernel.org>; Daniel
> Lezcano <daniel.lezcano@linaro.org>; Zhang Rui <rui.zhang@intel.com>;
> Lukasz Luba <lukasz.luba@arm.com>; Rob Herring <robh@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>;
> Henrik Grimler <henrik@grimler.se>
> Cc: linux-pm@vger.kernel.org; linux-samsung-soc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v3 1/3] dt-bindings: thermal: samsung: Add a hw-
> sensor-indices property
>
> On 15/09/2025 06:07, Shin Son wrote:
> > The exynosautov920 TMU requires per-sensor interrupt enablement for
> > its critical trip points.
> >
> > - **samsung,hw-sensor-indices**: List of sensor indices physically
> > monitored by this TMU block.
> > Indicies not listed exist in the SoC
> > register map but are not part of
> > this TMU instance
>
> Not much improved here. Same comment as before. That's not even correct
> syntax but some oddly formatted code. I asked to drop it and instead
> describe hardware. This is not a place to write some **code** or whatever
> this paragraph is about to represent.

Understood—sorry for the confusion. I'll remove the code-like formatting and replace it with a plain, hardware-focused
Description as requested.

>
> >
> > Additionally, add myself to the bindings' maintainers list, as I plan
> > to actively work on the exynosautov920 TMU support and handle further
> > updates in this area.
> > I also restrict 'samsung,hw-sensor-indices' to the V920 variant. To
> > ensure properties introduced in 'if/then' blocks are recognized, I
> > replace 'addtionalProperties: false' with 'unevaluatedProperties: false'.
>
> No, don't do that.

Understood. I'll keep 'addtionalProperties: false' as is and promote 'samsung,hw-sensor-indices' to the common sections.

>
> >
> > Signed-off-by: Shin Son <shin.son@samsung.com>
> > ---
> > .../thermal/samsung,exynos-thermal.yaml | 40 ++++++++++++++++++-
> > 1 file changed, 38 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yam
> > l
> > b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yam
> > l index 29a08b0729ee..448c68986b10 100644
> > ---
> > a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yam
> > l
> > +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal
> > +++ .yaml
> > @@ -8,6 +8,7 @@ title: Samsung Exynos SoC Thermal Management Unit
> > (TMU)
> >
> > maintainers:
> > - Krzysztof Kozlowski <krzk@kernel.org>
> > + - Shin Son <shin.son@samsung.com>
> >
> > description: |
> > For multi-instance tmu each instance should have an alias correctly
> > numbered @@ -27,6 +28,7 @@ properties:
> > - samsung,exynos5420-tmu-ext-triminfo
> > - samsung,exynos5433-tmu
> > - samsung,exynos7-tmu
> > + - samsung,exynosautov920-tmu
> >
> > clocks:
> > minItems: 1
> > @@ -62,7 +64,7 @@ properties:
> > minItems: 1
> >
> > '#thermal-sensor-cells':
> > - const: 0
> > + enum: [0, 1]
> >
> > vtmu-supply:
> > description: The regulator node supplying voltage to TMU.
> > @@ -97,6 +99,8 @@ allOf:
> > reg:
> > minItems: 2
> > maxItems: 2
> > + '#thermal-sensor-cells':
> > + const: 0
> > - if:
> > properties:
> > compatible:
> > @@ -119,6 +123,8 @@ allOf:
> > reg:
> > minItems: 1
> > maxItems: 1
> > + '#thermal-sensor-cells':
> > + const: 0
> >
> > - if:
> > properties:
> > @@ -139,8 +145,38 @@ allOf:
> > reg:
> > minItems: 1
> > maxItems: 1
> > + '#thermal-sensor-cells':
> > + const: 0
> >
> > -additionalProperties: false
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: samsung,exynosautov920-tmu
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 1
> > + maxItems: 1
> > + reg:
> > + minItems: 1
> > + maxItems: 1
> > + '#thermal-sensor-cells':
> > + const: 1
> > + samsung,hw-sensor-indices:
> > + description:
> > + List of thermal sensor indices physically monitored by this
> TMU instance.
> > + Indices not listed correspond to registers that exist in the
> SoC
> > + but are not connected to this TMU hardware block.
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
>
> I don't understand what is happening here with this binding. See writing
> schema and example-schema.
>
>
>
> Best regards,
> Krzysztof

Understood. I'll rework the binding to follow the 'writing schema' and 'example-schema' guidance
and include these changes in v4.

Thanks.
Best regards,
Shin Son