Re: [PATCH v2 1/3] dt-bindings: power: reset: atmel,sama5d2-shdwc: add lpm binding

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

On Tue, Sep 16, 2025 at 12:50:30PM -0700, Ryan.Wanner@microchip.com wrote:
> From: Varshini Rajendran <varshini.rajendran@microchip.com>
> 
> Add microchip,lpm-connection binding which allows to specify the devices
> the SHDWC's Low Power Mode pin is connected to.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> [ryan.wanner@microchip.com: Add sam9x7-shdwc SoC to properties check]
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
>  .../power/reset/atmel,sama5d2-shdwc.yaml      | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/atmel,sama5d2-shdwc.yaml b/Documentation/devicetree/bindings/power/reset/atmel,sama5d2-shdwc.yaml
> index 9c34249b2d6d..668b541eb44c 100644
> --- a/Documentation/devicetree/bindings/power/reset/atmel,sama5d2-shdwc.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/atmel,sama5d2-shdwc.yaml
> @@ -56,6 +56,13 @@ properties:
>      description: enable real-time timer wake-up
>      type: boolean
>  
> +  microchip,lpm-connection:
> +    description:
> +      List of phandles to devices which are connected to SHDWC's Low Power Mode Pin.
> +      The LPM pin is used to idicate to an external power supply or device to enter
> +      or exit a special powering state.
> +    $ref: /schemas/types.yaml#/definitions/phandle-array

This sounds like you're some kind of power-domain provider. Why doesn't
that generic kind of thing work for you?

> +
>  patternProperties:
>    "^input@[0-15]$":
>      description:
> @@ -96,6 +103,18 @@ allOf:
>        properties:
>          atmel,wakeup-rtt-timer: false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - atmel,sama5d2-shdwc
> +              - microchip,sam9x60-shdwc
> +              - microchip,sam9x7-shdwc
> +    then:
> +      properties:
> +        microchip,lpm-connection: false
> +
>  additionalProperties: false
>  
>  examples:
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]