From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EB55313D75; Fri, 19 Sep 2025 13:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758290377; cv=none; b=W2edY/+P0Fi1PGfn2KZTNU+2wOiRwszIxTncm2V3YFzXU3dKCIif7wt3Wtpt8UgU8i+4Y4XmEUxg6SuyWlAlA9nePtUfsqdBJOcHCpeYNpcHnvDpl6HuyY3UvI8orNWdYrzG6KZajGrg0LembbO7e08RNo7T4fL+Rym2tILo9Rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758290377; c=relaxed/simple; bh=G+eKhQdY3LXsknfdquHgWXFZCZJaYm8/KtCWfTr3cUA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cbsjHhFOP/Bfcm2Nsu5eToAoR8fXH9bmdNap+6hNBTZNkS1q4q23Knv15KfdxIrv5/29YVO3CIJNB4htKWWHv3ktNwNwc6iVwQQ6uS6gKfG49wqY7zJTTeMu15S9pztOQZXcjHyYQGYYD2GFaI0wg+83zkR8IKfgsm21w+Z/NR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FuaBUzXS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FuaBUzXS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E045C4CEF5; Fri, 19 Sep 2025 13:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758290377; bh=G+eKhQdY3LXsknfdquHgWXFZCZJaYm8/KtCWfTr3cUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FuaBUzXS0qCl6HAJ4XYjHQp6it8Dm536/l+ZByopsVOtdtZ/m3yVdkKgZIERvVALP nrWyMbs/HCYptk+HuEp9y/UxEBUEBwq4i478l52wlAqBpQ2QcqULucRqK3+Fyu9k7b ygJGYPQ9kxlywpHj5HihIV09eFg543KFXH4iaKZE= Date: Fri, 19 Sep 2025 15:59:32 +0200 From: Greg KH To: Andy Shevchenko Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andy Shevchenko , AngeloGioacchino Del Regno , sboyd@kernel.org, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, arnd@arndb.de, srini@kernel.org, vkoul@kernel.org, kishon@kernel.org, sre@kernel.org, krzysztof.kozlowski@linaro.org, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, kernel@collabora.com, wenst@chromium.org, casey.connolly@linaro.org, Konrad Dybcio , Neil Armstrong Subject: Re: [PATCH v4 2/7] nvmem: qcom-spmi-sdam: Migrate to devm_spmi_subdevice_alloc_and_add() Message-ID: <2025091925-thirsting-underuse-14ab@gregkh> References: <20250916084445.96621-1-angelogioacchino.delregno@collabora.com> <20250916084445.96621-3-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Sep 18, 2025 at 10:00:29PM +0300, Andy Shevchenko wrote: > I,o.w. I principally disagree on putting MODULE_IMPORT_NS() into the header > file. Yes, please never do that, it defeats the purpose of module namespaces completly. If you don't want to have module namespaces, don't use them for your subsytem. Don't use them and then make them moot by putting MODULE_IMPORT_NS() in the .h file for the symbols as that's pointless. thanks, greg k-h