Re: [PATCH v7 2/3] cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use

[Bjorn Helgaas <helgaas@kernel.org>]

[cc->to: Rafael, Daniel, any feedback or ack?  Would like to resolve
this (part of Aaron's series at
https://lore.kernel.org/r/20250731-pci-tegra-module-v7-0-cad4b088b8fb@gmail.com)]

On Thu, Jul 31, 2025 at 04:59:25PM -0500, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> Add export for tegra_cpuidle_pcie_irqs_in_use() so that drivers like
> pci-tegra can be loaded as a module.
> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  drivers/cpuidle/cpuidle-tegra.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c
> index b203a93deac5f378572be90e22c73e7417adb99e..aca907a62bb5de4ee4c71c1900eacedd4b90bc0a 100644
> --- a/drivers/cpuidle/cpuidle-tegra.c
> +++ b/drivers/cpuidle/cpuidle-tegra.c
> @@ -336,6 +336,7 @@ void tegra_cpuidle_pcie_irqs_in_use(void)
>  	pr_info("disabling CC6 state, since PCIe IRQs are in use\n");
>  	tegra_cpuidle_disable_state(TEGRA_CC6);
>  }
> +EXPORT_SYMBOL_GPL(tegra_cpuidle_pcie_irqs_in_use);

tegra_cpuidle_pcie_irqs_in_use() looks like a workaround for a Tegra20
hardware defect, and having no knowledge of typical Tegra20 systems,
my questions would be "Why do we even bother with this?  Should
cpuidle-tegra.c just disable CC6 always, unconditionally?  The whole
thing, and all of include/soc/tegra/cpuidle.h, looks like it might be
more trouble than it's worth."

Bjorn