Re: [PATCH V7 3/5] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 19 Sep 2025 20:17:43 +0530
Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> wrote:

> Hi Krzysztof,
> 
> On 9/18/2025 5:45 AM, Krzysztof Kozlowski wrote:
> > On 18/09/2025 04:47, Jishnu Prakash wrote:  
> >> Hi Krzysztof,
> >>
> >> On 9/17/2025 5:59 AM, Krzysztof Kozlowski wrote:  
> >>> On 16/09/2025 16:28, Jishnu Prakash wrote:  
> >>>>> You cannot have empty spaces in ID constants. These are abstract
> >>>>> numbers.
> >>>>>
> >>>>> Otherwise please point me to driver using this constant.  
> >>>>
> >>>> These constants are for ADC channel numbers, which are fixed in HW.
> >>>>
> >>>> They are used in this driver: drivers/iio/adc/qcom-spmi-adc5-gen3.c,
> >>>> which is added in patch 4 of this series.
> >>>>
> >>>> They can be found in the array named adc5_gen3_chans_pmic[].  
> >>>
> >>> Really? So point me to the line there using ADC5_GEN3_VREF_BAT_THERM.
> >>>  
> >>
> >> We may not be using all of these channels right now - we can add them
> >> later based on requirements coming up. For now, I'll remove the channels
> >> not used in adc5_gen3_chans_pmic[].  
> > 
> > You are not implementing the feedback then. Please read it carefully.
> >   
> 
> Sorry, I misunderstood - so you actually meant I should remove the
> empty spaces in the definitions, like this?
> 
> -#define ADC5_GEN3_VREF_BAT_THERM               0x15
> +#define ADC5_GEN3_VREF_BAT_THERM 0x15
> 
> I thought this at first, but I somehow doubted this later, as I saw some
> other recently added files with empty spaces in #define lines, like:
> 
> include/dt-bindings/iio/adc/mediatek,mt6373-auxadc.h
> include/dt-bindings/regulator/st,stm32mp15-regulator.h
> 
> I can make this change, if you prefer this. Please let me know
> if I'm still missing something.
> 
> Also please let me know if you want me to remove the unused
> channels - I would prefer to keep them if there's no issue,
> as we might need them later.
> 
He is referring to 0x14 and below not being defined values.  So what
do they mean if they turn up in the DT?

Hence the request for context on how this define is being used so that
you can get some feedback on how it should be done.

J
> Thanks,
> Jishnu
> 
> > Best regards,
> > Krzysztof  
>