From: Dhruva Gole <d-gole@ti.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Sebastian Reichel <sre@kernel.org>, <linux-pm@vger.kernel.org>,
Hans de Goede <hansg@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: supply: use ktime_divns() to avoid 64-bit division
Date: Wed, 15 Oct 2025 17:27:29 +0530 [thread overview]
Message-ID: <20251015115729.64eglmp262u7g3so@lcpd911> (raw)
In-Reply-To: <20251015075957.8F40620057@lion.mk-sys.cz>
On Oct 15, 2025 at 09:56:31 +0200, Michal Kubecek wrote:
> The build of intel_dc_ti_battery module on i386 (32-bit) fails with
>
> ERROR: modpost: "__udivdi3" [drivers/power/supply/intel_dc_ti_battery.ko]
>
> This is caused by 64-bit division of ktime values by NSEC_PER_USEC. Use
> ktime_divns() helper which handles the division correctly on 32-bit
> architectures.
>
> Fixes: 8c5795fe5527 ("power: supply: Add new Intel Dollar Cove TI battery driver")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> ---
Good catch!
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Best regards,
Dhruva Gole
Texas Instruments Incorporated
next prev parent reply other threads:[~2025-10-15 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 7:56 [PATCH] power: supply: use ktime_divns() to avoid 64-bit division Michal Kubecek
2025-10-15 10:04 ` Hans de Goede
2025-10-15 11:57 ` Dhruva Gole [this message]
2025-11-03 0:48 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015115729.64eglmp262u7g3so@lcpd911 \
--to=d-gole@ti.com \
--cc=hansg@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox