From: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
To: rafael@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com, srinivas.pandruvada@linux.intel.com
Cc: linux-pm@vger.kernel.org,
Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Subject: [PATCH] thermal: Fix UUID string comparison in current_uuid_store()
Date: Fri, 17 Oct 2025 12:57:03 +0530 [thread overview]
Message-ID: <20251017072703.2064390-1-kaushlendra.kumar@intel.com> (raw)
Use strlen() for UUID matching instead of sizeof() to ensure
correct comparison of supported UUIDs. sizeof() returns pointer
size instead of actual string length, causing incomplete UUID
matching.
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index 908cc1bf57f1..236003d12dc7 100644
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -199,7 +199,7 @@ static ssize_t current_uuid_store(struct device *dev,
for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; ++i) {
if (!strncmp(buf, int3400_thermal_uuids[i],
- sizeof(int3400_thermal_uuids[i]) - 1)) {
+ strlen(int3400_thermal_uuids[i]))) {
/*
* If we have a list of supported UUIDs, make sure
* this one is supported.
--
2.34.1
next reply other threads:[~2025-10-17 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 7:27 Kaushlendra Kumar [this message]
2025-10-29 16:40 ` [PATCH] thermal: Fix UUID string comparison in current_uuid_store() Rafael J. Wysocki
2025-10-29 18:40 ` Rafael J. Wysocki
2025-10-30 4:04 ` Kumar, Kaushlendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017072703.2064390-1-kaushlendra.kumar@intel.com \
--to=kaushlendra.kumar@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).