From: Ally Heev <allyheev@gmail.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Joe Perches <joe@perches.com>, Jonathan Corbet <corbet@lwn.net>,
Andy Whitcroft <apw@canonical.com>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
David Hunter <david.hunter.linux@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-pm <linux-pm@vger.kernel.org>,
dan.j.williams@intel.com, Ally Heev <allyheev@gmail.com>
Subject: [PATCH v2 0/2] checkpatch: add checks incorrectly initialized pointers with __free attr
Date: Fri, 24 Oct 2025 22:59:14 +0530 [thread overview]
Message-ID: <20251024-aheev-checkpatch-uninitialized-free-v2-0-16c0900e8130@gmail.com> (raw)
Badly initialized pointers with __free attr can
cause cleanup issues. So,
Adding checks for
- uninitialized pointers
- initialized pointers with NULL
Testing:
ran checkpatch.pl before and after the change on
crypto/asymmetric_keys/x509_public_key.c, which has
both initialized with NULL and uninitialized pointers
---
Changes in v2:
- change cover letter and title to reflect new changes
- fix regex to handle multiple declarations in a single line case
- convert WARN to ERROR for uninitialized pointers
- add a new WARN for pointers initialized with NULL
- NOTE: tried handling multiple declarations on a single line by splitting
them and matching the parts with regex, but, it turned out to be
complex and overkill. Moreover, multi-line declarations pose a threat
- Link to v1: https://lore.kernel.org/r/20251021-aheev-checkpatch-uninitialized-free-v1-1-18fb01bc6a7a@gmail.com
---
Ally Heev (2):
checkpatch: add uninitialized pointer with __free attribute check
add check for pointers with __free attribute initialized to NULL
Documentation/dev-tools/checkpatch.rst | 11 +++++++++++
scripts/checkpatch.pl | 13 +++++++++++++
2 files changed, 24 insertions(+)
---
base-commit: 6548d364a3e850326831799d7e3ea2d7bb97ba08
change-id: 20251021-aheev-checkpatch-uninitialized-free-5c39f75e10a1
Best regards,
--
Ally Heev <allyheev@gmail.com>
next reply other threads:[~2025-10-24 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 17:29 Ally Heev [this message]
2025-10-24 17:29 ` [PATCH v2 1/2] checkpatch: add uninitialized pointer with __free attribute check Ally Heev
2025-10-24 18:14 ` Joe Perches
2025-10-25 3:37 ` ally heev
2025-10-24 17:29 ` [PATCH v2 2/2] add check for pointers with __free attribute initialized to NULL Ally Heev
2025-10-24 18:01 ` Joe Perches
2025-10-24 18:14 ` dan.j.williams
2025-10-24 18:23 ` Joe Perches
2025-10-24 18:37 ` dan.j.williams
2025-10-25 6:17 ` ally heev
2025-10-24 18:08 ` Dan Carpenter
2025-10-25 6:23 ` ally heev
2025-10-27 5:27 ` Dan Carpenter
2025-10-27 8:34 ` ally heev
2025-10-25 6:29 ` ally heev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024-aheev-checkpatch-uninitialized-free-v2-0-16c0900e8130@gmail.com \
--to=allyheev@gmail.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=david.hunter.linux@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vireshk@kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).