Re: [PATCH v3 2/6] thermal/drivers/sun8i: add gpadc clock

Chen-Yu Tsai
2025-10-27T02:45:16Z

On Sat, Oct 25, 2025 at 12:32 PM iuncuim <iuncuim@gmail.com> wrote:
>
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> Some processors (e.g. Allwinner A523) require GPADC clocking activation for
> temperature sensors to work. So let's add support for enabling it.
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>

Reviewed-by: Chen-Yu Tsai <wens@kernel.org>

> ---
> drivers/thermal/sun8i_thermal.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 226747906..c02c398b0 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -66,6 +66,7 @@ struct tsensor {
> };
>
> struct ths_thermal_chip {
> + bool has_gpadc_clk;
> bool has_mod_clk;
> bool has_bus_clk_reset;
> bool needs_sram;

We could optimize this using bit fields instead. This can be done in a later
patch if you want to do it.

ChenYu

> @@ -89,6 +90,7 @@ struct ths_device {
> struct regmap_field *sram_regmap_field;
> struct reset_control *reset;
> struct clk *bus_clk;
> + struct clk *gpadc_clk;
> struct clk *mod_clk;
> struct tsensor sensor[MAX_SENSOR_NUM];
> };
> @@ -417,6 +419,12 @@ static int sun8i_ths_resource_init(struct ths_device *tmdev)
> if (ret)
> return ret;
>
> + if (tmdev->chip->has_gpadc_clk) {
> + tmdev->gpadc_clk = devm_clk_get_enabled(&pdev->dev, "gpadc");
> + if (IS_ERR(tmdev->gpadc_clk))
> + return PTR_ERR(tmdev->gpadc_clk);
> + }
> +
> if (tmdev->chip->needs_sram) {
> struct regmap *regmap;
>
> --
> 2.51.0
>
>