Re: [PATCH v3 1/6] dt-bindings: thermal: sun8i: Add A523 THS0/1 controllers

Jernej Škrabec
2025-10-27T18:01:44Z

Hi,

Dne nedelja, 26. oktober 2025 ob 22:09:05 Srednjeevropski standardni čas je Rob Herring napisal(a):
> On Sat, Oct 25, 2025 at 12:31:24PM +0800, iuncuim wrote:
> > From: Mikhail Kalashnikov <iuncuim@gmail.com>
> >
> > Add a binding for D1/T113s thermal sensor controller. Add dt-bindings
> > description of the thermal sensors in the A523 processor.
> > The controllers require activation of the additional frequency of the
> > associated gpadc controller, so a new clock property has been added.
> >
> > The calibration data is split into two cells that are in different areas
> > of nvmem. Both controllers require access to both memory cell, so a new
> > property nvmem-cells has been added. To maintain backward compatibility,
> > the name of the old cell remains the same and the new nvmem-cell-names is
> > called calibration-second-part
> >
> > Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> > ---
> > .../thermal/allwinner,sun8i-a83t-ths.yaml | 56 ++++++++++++++++++-
> > 1 file changed, 53 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> > index 3e61689f6..b2f750ef2 100644
> > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> > @@ -24,18 +24,23 @@ properties:
> > - allwinner,sun50i-h5-ths
> > - allwinner,sun50i-h6-ths
> > - allwinner,sun50i-h616-ths
> > + - allwinner,sun55i-a523-ths0
> > + - allwinner,sun55i-a523-ths1
> >
> > clocks:
> > minItems: 1
> > items:
> > - description: Bus Clock
> > - description: Module Clock
> > + - description: GPADC Clock
> >
> > clock-names:
> > minItems: 1
> > + maxItems: 2
>
> How can the max be both 2 and...
>
> > items:
> > - const: bus
> > - const: mod
> > + - const: gpadc
>
> ...3 entries?
>

Because old variant uses "bus" and "mod" and new variant uses "bus" and
"gpadc" and none of them uses all 3 entries.

Although, I guess we can simplify and just use "mod" in both cases.

Best regards,
Jernej