Linux Power Management development
 help / color / mirror / Atom feed
From: Askar Safin <safinaskar@gmail.com>
To: rafael@kernel.org
Cc: gregkh@linuxfoundation.org, guoqing.zhang@amd.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	mario.limonciello@amd.com, todd.e.brandt@linux.intel.com,
	torvalds@linuxfoundation.org,
	"regressions" <regressions@lists.linux.dev>
Subject: [REGRESSION][BISECTED] Hibernation: WARNING at kernel/power/main.c:48 pm_restrict_gfp_mask (was: "[PATCH v1] PM: hibernate: Restrict GFP mask in hibernation_snapshot()")
Date: Sat, 25 Oct 2025 08:08:12 +0300	[thread overview]
Message-ID: <20251025050812.421905-1-safinaskar@gmail.com> (raw)
In-Reply-To: <5924662.DvuYhMxLoT@rafael.j.wysocki>

"Rafael J. Wysocki" <rafael@kernel.org>:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Commit 12ffc3b1513e ("PM: Restrict swap use to later in the suspend
> sequence") incorrectly removed a pm_restrict_gfp_mask() call from
> hibernation_snapshot(), so memory allocations involving swap are not
> prevented from being carried out in this code path any more which may
> lead to serious breakage.

#regzbot introduced: 449c9c02537a146ac97ef962327a221e21c9cab3

This commit introduced regression: now I see WARNING every time when
I hibernate. The bug reproduces both on real hardware and in Qemu.

Here is script I used to reproduce this bug in Qemu:
https://zerobin.net/?aadae7117a208c0a#Xh8aI5+u3pyk+vKwET7j+yXolLeoSLe/AedcvnNeCLs=

Here is resulting log (dmesg) on current master (43e9ad0c55a3):
https://zerobin.net/?471d17d0632e7f85#uYne0yUu+rP4KnDbOFFqtCrcDIi6UpQz2uIQw85lcdQ=

Here is the most interesting part:

[    1.735001] PM: Image saving progress:  90%
[    1.746611] PM: Image saving progress: 100%
[    1.747208] PM: Image saving done
[    1.747403] PM: hibernation: Wrote 30164 kbytes in 0.13 seconds (232.03 MB/s)
[    1.747837] PM: Image size after compression: 8908 kbytes
[    1.748190] PM: S|
[    1.750351] ------------[ cut here ]------------
[    1.750627] WARNING: CPU: 0 PID: 1 at kernel/power/main.c:48 pm_restrict_gfp_mask+0x3b/0x40

On real hardware exactly same thing happens (i. e. WARNING at kernel/power/main.c:48 pm_restrict_gfp_mask).

-- 
Askar Safin

  parent reply	other threads:[~2025-10-25  5:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10  9:41 [PATCH v1] PM: hibernate: Restrict GFP mask in hibernation_snapshot() Rafael J. Wysocki
2025-09-10 18:26 ` Mario Limonciello
2025-10-25  5:08 ` Askar Safin [this message]
2025-10-26  1:31   ` [REGRESSION][BISECTED] Hibernation: WARNING at kernel/power/main.c:48 pm_restrict_gfp_mask (was: "[PATCH v1] PM: hibernate: Restrict GFP mask in hibernation_snapshot()") Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251025050812.421905-1-safinaskar@gmail.com \
    --to=safinaskar@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guoqing.zhang@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=rafael@kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=todd.e.brandt@linux.intel.com \
    --cc=torvalds@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox