From: Rob Herring <robh@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Ilia Lin <ilia.lin@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 1/1] cpufreq: qcom-nvmem: add compatible fallback for ipq806x for no SMEM
Date: Tue, 18 Nov 2025 13:10:18 -0600 [thread overview]
Message-ID: <20251118191018.GA3997357-robh@kernel.org> (raw)
In-Reply-To: <20251105112136.371376-2-ansuelsmth@gmail.com>
On Wed, Nov 05, 2025 at 12:21:34PM +0100, Christian Marangi wrote:
> On some IPQ806x SoC SMEM might be not initialized by SBL. This is the
> case for some Google devices (the OnHub family) that can't make use of
> SMEM to detect the SoC ID (and socinfo can't be used either as it does
> depends on SMEM presence).
>
> To handle these specific case, check if the SMEM is not initialized (by
> checking if the qcom_smem_get_soc_id returns -ENODEV) and fallback to
> OF machine compatible checking to identify the SoC variant.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 35 ++++++++++++++++++++++++++--
> 1 file changed, 33 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index 3a8ed723a23e..be44a8965e3a 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -252,13 +252,22 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev,
> return ret;
> }
>
> +static const struct of_device_id qcom_cpufreq_ipq806x_match_list[] = {
> + { .compatible = "qcom,ipq8062", .data = (const void *)QCOM_ID_IPQ8062 },
> + { .compatible = "qcom,ipq8064", .data = (const void *)QCOM_ID_IPQ8064 },
> + { .compatible = "qcom,ipq8065", .data = (const void *)QCOM_ID_IPQ8065 },
> + { .compatible = "qcom,ipq8066", .data = (const void *)QCOM_ID_IPQ8066 },
> + { .compatible = "qcom,ipq8068", .data = (const void *)QCOM_ID_IPQ8068 },
> + { .compatible = "qcom,ipq8069", .data = (const void *)QCOM_ID_IPQ8069 },
These are all undocumented:
qcom,ipq8062
qcom,ipq8066
qcom,ipq8068
qcom,ipq8069
Rob
next prev parent reply other threads:[~2025-11-18 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 11:21 [PATCH v4 0/1] cpufreq: qcom: handle ipq806x with no SMEM Christian Marangi
2025-11-05 11:21 ` [PATCH v4 1/1] cpufreq: qcom-nvmem: add compatible fallback for ipq806x for " Christian Marangi
2025-11-10 10:47 ` Viresh Kumar
2025-11-18 19:10 ` Rob Herring [this message]
2025-11-18 21:45 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118191018.GA3997357-robh@kernel.org \
--to=robh@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ilia.lin@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).