Re: [PATCH] pmdomain: mediatek: Break lock dependency to `prepare_lock`

[kernel test robot <lkp@intel.com>]

Hi Tzung-Bi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.19-rc3 next-20251219]
[cannot apply to amd-pstate/linux-next amd-pstate/bleeding-edge]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tzung-Bi-Shih/pmdomain-mediatek-Break-lock-dependency-to-prepare_lock/20251229-123525
base:   linus/master
patch link:    https://lore.kernel.org/r/20251229043244.4103262-1-tzungbi%40kernel.org
patch subject: [PATCH] pmdomain: mediatek: Break lock dependency to `prepare_lock`
config: arm-randconfig-003-20251230 (https://download.01.org/0day-ci/archive/20251230/202512302129.BjTBw9E6-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251230/202512302129.BjTBw9E6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512302129.BjTBw9E6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pmdomain/mediatek/mtk-pm-domains.c:1304:12: warning: 'scpsys_resume' defined but not used [-Wunused-function]
    1304 | static int scpsys_resume(struct device *dev)
         |            ^~~~~~~~~~~~~
>> drivers/pmdomain/mediatek/mtk-pm-domains.c:1285:12: warning: 'scpsys_suspend' defined but not used [-Wunused-function]
    1285 | static int scpsys_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~


vim +/scpsys_resume +1304 drivers/pmdomain/mediatek/mtk-pm-domains.c

  1284	
> 1285	static int scpsys_suspend(struct device *dev)
  1286	{
  1287		struct scpsys *scpsys = dev_get_drvdata(dev);
  1288		struct generic_pm_domain *genpd;
  1289		struct scpsys_domain *pd;
  1290		int i;
  1291	
  1292		for (i = 0; i < scpsys->pd_data.num_domains; i++) {
  1293			genpd = scpsys->pd_data.domains[i];
  1294			if (!genpd)
  1295				continue;
  1296	
  1297			pd = to_scpsys_domain(genpd);
  1298			clk_bulk_unprepare(pd->num_clks, pd->clks);
  1299			clk_bulk_unprepare(pd->num_subsys_clks, pd->subsys_clks);
  1300		}
  1301		return 0;
  1302	}
  1303	
> 1304	static int scpsys_resume(struct device *dev)
  1305	{
  1306		struct scpsys *scpsys = dev_get_drvdata(dev);
  1307		struct generic_pm_domain *genpd;
  1308		struct scpsys_domain *pd;
  1309		int i, ret;
  1310	
  1311		for (i = 0; i < scpsys->pd_data.num_domains; i++) {
  1312			genpd = scpsys->pd_data.domains[i];
  1313			if (!genpd)
  1314				continue;
  1315	
  1316			pd = to_scpsys_domain(genpd);
  1317			ret = clk_bulk_prepare(pd->num_clks, pd->clks);
  1318			if (ret)
  1319				return ret;
  1320			ret = clk_bulk_prepare(pd->num_subsys_clks, pd->subsys_clks);
  1321			if (ret)
  1322				return ret;
  1323		}
  1324		return 0;
  1325	}
  1326	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki