* [PATCH] thermal: intel: Use sysfs_emit in sysfs show functions
@ 2026-01-13 8:21 Thorsten Blum
2026-01-15 20:22 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-01-13 8:21 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Peter Zijlstra (Intel), Ingo Molnar
Cc: Thorsten Blum, linux-pm, linux-kernel
Replace sprintf() with sysfs_emit() in sysfs show functions.
sysfs_emit() is preferred to format sysfs output as it provides better
bounds checking.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/thermal/intel/therm_throt.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/intel/therm_throt.c b/drivers/thermal/intel/therm_throt.c
index debc94e2dc16..44fa4dd15dd1 100644
--- a/drivers/thermal/intel/therm_throt.c
+++ b/drivers/thermal/intel/therm_throt.c
@@ -23,6 +23,7 @@
#include <linux/types.h>
#include <linux/init.h>
#include <linux/smp.h>
+#include <linux/sysfs.h>
#include <linux/cpu.h>
#include <asm/processor.h>
@@ -144,8 +145,8 @@ static ssize_t therm_throt_device_show_##event##_##name( \
\
preempt_disable(); /* CPU hotplug */ \
if (cpu_online(cpu)) { \
- ret = sprintf(buf, "%lu\n", \
- per_cpu(thermal_state, cpu).event.name); \
+ ret = sysfs_emit(buf, "%lu\n", \
+ per_cpu(thermal_state, cpu).event.name); \
} else \
ret = 0; \
preempt_enable(); \
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thermal: intel: Use sysfs_emit in sysfs show functions
2026-01-13 8:21 [PATCH] thermal: intel: Use sysfs_emit in sysfs show functions Thorsten Blum
@ 2026-01-15 20:22 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2026-01-15 20:22 UTC (permalink / raw)
To: Thorsten Blum
Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Peter Zijlstra (Intel), Ingo Molnar, linux-pm, linux-kernel
On Tue, Jan 13, 2026 at 9:22 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Replace sprintf() with sysfs_emit() in sysfs show functions.
> sysfs_emit() is preferred to format sysfs output as it provides better
> bounds checking.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/thermal/intel/therm_throt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/therm_throt.c b/drivers/thermal/intel/therm_throt.c
> index debc94e2dc16..44fa4dd15dd1 100644
> --- a/drivers/thermal/intel/therm_throt.c
> +++ b/drivers/thermal/intel/therm_throt.c
> @@ -23,6 +23,7 @@
> #include <linux/types.h>
> #include <linux/init.h>
> #include <linux/smp.h>
> +#include <linux/sysfs.h>
> #include <linux/cpu.h>
>
> #include <asm/processor.h>
> @@ -144,8 +145,8 @@ static ssize_t therm_throt_device_show_##event##_##name( \
> \
> preempt_disable(); /* CPU hotplug */ \
> if (cpu_online(cpu)) { \
> - ret = sprintf(buf, "%lu\n", \
> - per_cpu(thermal_state, cpu).event.name); \
> + ret = sysfs_emit(buf, "%lu\n", \
> + per_cpu(thermal_state, cpu).event.name); \
> } else \
> ret = 0; \
> preempt_enable(); \
> --
Applied as 6.20 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-15 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-13 8:21 [PATCH] thermal: intel: Use sysfs_emit in sysfs show functions Thorsten Blum
2026-01-15 20:22 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox