* [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
@ 2026-01-17 21:09 Val Packett
2026-01-19 6:38 ` Dmitry Baryshkov
0 siblings, 1 reply; 4+ messages in thread
From: Val Packett @ 2026-01-17 21:09 UTC (permalink / raw)
To: Sebastian Reichel, Abel Vesa, Dmitry Baryshkov
Cc: Val Packett, Sebastian Reichel, linux-arm-msm, linux-pm,
linux-kernel
On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
for the battery chemistry type, but only all-uppercase "LIP" was being
recognized. Add the CamelCase variant to the check to fix the "Unknown
battery technology" warning.
Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
Signed-off-by: Val Packett <val@packett.cool>
---
drivers/power/supply/qcom_battmgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
index c8028606bba0..80e701c66434 100644
--- a/drivers/power/supply/qcom_battmgr.c
+++ b/drivers/power/supply/qcom_battmgr.c
@@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry
if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
(!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
return POWER_SUPPLY_TECHNOLOGY_LION;
- if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
+ if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) ||
+ (!strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN)))
return POWER_SUPPLY_TECHNOLOGY_LIPO;
pr_err("Unknown battery technology '%s'\n", chemistry);
--
2.51.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
2026-01-17 21:09 [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer Val Packett
@ 2026-01-19 6:38 ` Dmitry Baryshkov
2026-01-20 23:14 ` Val Packett
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-01-19 6:38 UTC (permalink / raw)
To: Val Packett
Cc: Sebastian Reichel, Abel Vesa, Sebastian Reichel, linux-arm-msm,
linux-pm, linux-kernel
On Sat, Jan 17, 2026 at 06:09:24PM -0300, Val Packett wrote:
> On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
> for the battery chemistry type, but only all-uppercase "LIP" was being
> recognized. Add the CamelCase variant to the check to fix the "Unknown
> battery technology" warning.
>
> Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> drivers/power/supply/qcom_battmgr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
> index c8028606bba0..80e701c66434 100644
> --- a/drivers/power/supply/qcom_battmgr.c
> +++ b/drivers/power/supply/qcom_battmgr.c
> @@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry
> if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
> (!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
> return POWER_SUPPLY_TECHNOLOGY_LION;
> - if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
> + if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) ||
> + (!strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN)))
Why do you have extra brackets around the second strncmp?
> return POWER_SUPPLY_TECHNOLOGY_LIPO;
>
> pr_err("Unknown battery technology '%s'\n", chemistry);
> --
> 2.51.2
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
2026-01-19 6:38 ` Dmitry Baryshkov
@ 2026-01-20 23:14 ` Val Packett
2026-01-20 23:35 ` Dmitry Baryshkov
0 siblings, 1 reply; 4+ messages in thread
From: Val Packett @ 2026-01-20 23:14 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Sebastian Reichel, Abel Vesa, Sebastian Reichel, linux-arm-msm,
linux-pm, linux-kernel
On 1/19/26 3:38 AM, Dmitry Baryshkov wrote:
> On Sat, Jan 17, 2026 at 06:09:24PM -0300, Val Packett wrote:
>> On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
>> for the battery chemistry type, but only all-uppercase "LIP" was being
>> recognized. Add the CamelCase variant to the check to fix the "Unknown
>> battery technology" warning.
>>
>> Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
>> Signed-off-by: Val Packett <val@packett.cool>
>> ---
>> drivers/power/supply/qcom_battmgr.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
>> index c8028606bba0..80e701c66434 100644
>> --- a/drivers/power/supply/qcom_battmgr.c
>> +++ b/drivers/power/supply/qcom_battmgr.c
>> @@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry
>> if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
>> (!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
>> return POWER_SUPPLY_TECHNOLOGY_LION;
>> - if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
>> + if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) ||
>> + (!strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN)))
> Why do you have extra brackets around the second strncmp?
Copy-pasted from the line above (the "OOI" one) :) Didn't see that the
first one in this expression doesn't have them.
Feel free to edit this when applying
~val
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
2026-01-20 23:14 ` Val Packett
@ 2026-01-20 23:35 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-01-20 23:35 UTC (permalink / raw)
To: Val Packett
Cc: Sebastian Reichel, Abel Vesa, Sebastian Reichel, linux-arm-msm,
linux-pm, linux-kernel
On Tue, Jan 20, 2026 at 08:14:12PM -0300, Val Packett wrote:
>
> On 1/19/26 3:38 AM, Dmitry Baryshkov wrote:
> > On Sat, Jan 17, 2026 at 06:09:24PM -0300, Val Packett wrote:
> > > On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
> > > for the battery chemistry type, but only all-uppercase "LIP" was being
> > > recognized. Add the CamelCase variant to the check to fix the "Unknown
> > > battery technology" warning.
> > >
> > > Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
> > > Signed-off-by: Val Packett <val@packett.cool>
> > > ---
> > > drivers/power/supply/qcom_battmgr.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
> > > index c8028606bba0..80e701c66434 100644
> > > --- a/drivers/power/supply/qcom_battmgr.c
> > > +++ b/drivers/power/supply/qcom_battmgr.c
> > > @@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry
> > > if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
> > > (!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
> > > return POWER_SUPPLY_TECHNOLOGY_LION;
> > > - if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
> > > + if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) ||
> > > + (!strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN)))
> > Why do you have extra brackets around the second strncmp?
>
> Copy-pasted from the line above (the "OOI" one) :) Didn't see that the first
> one in this expression doesn't have them.
>
> Feel free to edit this when applying
It depends on Sebastian, but I'd kindly suggest sending v2.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-20 23:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-17 21:09 [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer Val Packett
2026-01-19 6:38 ` Dmitry Baryshkov
2026-01-20 23:14 ` Val Packett
2026-01-20 23:35 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox