Re: [PATCH v2 0/7] thermal: samsung: Add support for Google GS101 TMU

Tudor Ambarus
2026-03-03T09:01:46Z

On 3/2/26 8:30 PM, Alexey Klimov wrote:
> Hi Tudor,

Hi!

>
> On Sun, 1 Mar 2026 at 02:26, Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
>
> [...]
>
>> ---
>> Tudor Ambarus (7):
>> dt-bindings: thermal: Add Google GS101 TMU
>> firmware: samsung: acpm: Add TMU protocol support
>> firmware: samsung: acpm: Add devm_acpm_get_by_phandle helper
>> thermal: samsung: Add support for GS101 TMU
>> MAINTAINERS: Add entry for Samsung Exynos ACPM thermal driver
>> arm64: dts: exynos: gs101: Add thermal management unit
>> arm64: defconfig: enable Exynos ACPM thermal support
>>
>> .../bindings/thermal/google,gs101-tmu-top.yaml | 67 +++
>> MAINTAINERS | 8 +
>> arch/arm64/boot/dts/exynos/google/gs101-tmu.dtsi | 209 +++++++
>> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 18 +
>> arch/arm64/configs/defconfig | 1 +
>> drivers/firmware/samsung/Makefile | 1 +
>> drivers/firmware/samsung/exynos-acpm-tmu.c | 212 +++++++
>> drivers/firmware/samsung/exynos-acpm-tmu.h | 33 ++
>> drivers/firmware/samsung/exynos-acpm.c | 35 ++
>> drivers/thermal/samsung/Kconfig | 16 +
>> drivers/thermal/samsung/Makefile | 2 +
>> drivers/thermal/samsung/acpm-tmu.c | 643 +++++++++++++++++++++
>> .../linux/firmware/samsung/exynos-acpm-protocol.h | 30 +
>> 13 files changed, 1275 insertions(+)
>> ---
>> base-commit: e2211f5d980086dd9fbdab3bcd86b715e12cae13
>> change-id: 20260113-acpm-tmu-27e21f0e2c3b
>
> JFYI, the series doesn't clearly apply on today's linux-next:

okay, thanks. I'll submit a v2, but right now I'm dealing with other
higher priority topics.

>
> Grabbing thread from
> lore.kernel.org/all/20260119-acpm-tmu-v2-0-e02a834f04c6@linaro.org/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 18 messages in the thread
> Looking for additional code-review trailers on lore.kernel.org
> Analyzing 20 code-review messages
> Checking attestation on all messages, may take a moment...
>
> Base: using specified base-commit e2211f5d980086dd9fbdab3bcd86b715e12cae13
> Applying: dt-bindings: thermal: Add Google GS101 TMU
> Applying: firmware: samsung: acpm: Add TMU protocol support
> Patch failed at 0002 firmware: samsung: acpm: Add TMU protocol support
> error: patch failed: include/linux/firmware/samsung/exynos-acpm-protocol.h:40
> error: include/linux/firmware/samsung/exynos-acpm-protocol.h: patch
> does not apply
>
> Was it done against mainline?

Of course, yes. It was on top of what was the latest Samsung SoC tree
at the time of development. Internal kernel trees may change,
depending on the maintainer.

If you want to try the code while I submit a v2, I pushed what I
think it was v2 at:

git@github.com:ambarus/linux-0day.git, branch b4/acpm-tmu

Cheers,
ta