From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-pm@vger.kernel.org, jonas@kwiboo.se, pgwipeout@gmail.com,
finley.xiao@rock-chips.com, kever.yang@rock-chips.com,
shawn.lin@rock-chips.com, sebastian.reichel@collabora.com,
heiko@sntech.de, ulf.hansson@linaro.org,
Chris Morgan <macromorgan@hotmail.com>,
Diederik de Haas <diederik@cknow-tech.com>
Subject: [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER
Date: Fri, 30 Jan 2026 10:31:01 -0600 [thread overview]
Message-ID: <20260130163102.51757-1-macroalpha82@gmail.com> (raw)
From: Chris Morgan <macromorgan@hotmail.com>
Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
to prevent errors early in the boot process when the requested
regulator is not yet available. This converts errors like the following
to debug messages:
rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Tested-by: Diederik de Haas <diederik@cknow-tech.com>
---
Changes since v1:
- Simplified return to single line
---
drivers/pmdomain/rockchip/pm-domains.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
index 997e93c12951..6d3fb18f4ab3 100644
--- a/drivers/pmdomain/rockchip/pm-domains.c
+++ b/drivers/pmdomain/rockchip/pm-domains.c
@@ -705,10 +705,9 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
int ret;
ret = rockchip_pd_regulator_enable(pd);
- if (ret) {
- dev_err(pd->pmu->dev, "Failed to enable supply: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(pd->pmu->dev, ret,
+ "Failed to enable supply: %d\n", ret);
ret = rockchip_pd_power(pd, true);
if (ret)
--
2.43.0
next reply other threads:[~2026-01-30 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 16:31 Chris Morgan [this message]
2026-01-31 16:36 ` [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER Anand Moon
2026-03-03 0:49 ` Shawn Lin
2026-03-04 11:24 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130163102.51757-1-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=diederik@cknow-tech.com \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=pgwipeout@gmail.com \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox