* Re: [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER
2026-01-30 16:31 [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER Chris Morgan
@ 2026-01-31 16:36 ` Anand Moon
2026-03-03 0:49 ` Shawn Lin
2026-03-04 11:24 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Anand Moon @ 2026-01-31 16:36 UTC (permalink / raw)
To: Chris Morgan
Cc: linux-rockchip, linux-pm, jonas, pgwipeout, finley.xiao,
kever.yang, shawn.lin, sebastian.reichel, heiko, ulf.hansson,
Chris Morgan, Diederik de Haas
Hi Chris,
On Fri, 30 Jan 2026 at 22:03, Chris Morgan <macroalpha82@gmail.com> wrote:
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
> to prevent errors early in the boot process when the requested
> regulator is not yet available. This converts errors like the following
> to debug messages:
>
> rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Tested-by: Diederik de Haas <diederik@cknow-tech.com>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Thanks
-Anand
> ---
> Changes since v1:
> - Simplified return to single line
> ---
> drivers/pmdomain/rockchip/pm-domains.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> index 997e93c12951..6d3fb18f4ab3 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -705,10 +705,9 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
> int ret;
>
> ret = rockchip_pd_regulator_enable(pd);
> - if (ret) {
> - dev_err(pd->pmu->dev, "Failed to enable supply: %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(pd->pmu->dev, ret,
> + "Failed to enable supply: %d\n", ret);
>
> ret = rockchip_pd_power(pd, true);
> if (ret)
> --
> 2.43.0
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER
2026-01-30 16:31 [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER Chris Morgan
2026-01-31 16:36 ` Anand Moon
@ 2026-03-03 0:49 ` Shawn Lin
2026-03-04 11:24 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Lin @ 2026-03-03 0:49 UTC (permalink / raw)
To: Chris Morgan
Cc: shawn.lin, linux-pm, jonas, pgwipeout, finley.xiao, kever.yang,
sebastian.reichel, heiko, ulf.hansson, Chris Morgan,
Diederik de Haas, linux-rockchip
在 2026/01/31 星期六 0:31, Chris Morgan 写道:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
> to prevent errors early in the boot process when the requested
> regulator is not yet available. This converts errors like the following
> to debug messages:
>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Tested-by: Diederik de Haas <diederik@cknow-tech.com>
> ---
> Changes since v1:
> - Simplified return to single line
> ---
> drivers/pmdomain/rockchip/pm-domains.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> index 997e93c12951..6d3fb18f4ab3 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -705,10 +705,9 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
> int ret;
>
> ret = rockchip_pd_regulator_enable(pd);
> - if (ret) {
> - dev_err(pd->pmu->dev, "Failed to enable supply: %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(pd->pmu->dev, ret,
> + "Failed to enable supply: %d\n", ret);
>
> ret = rockchip_pd_power(pd, true);
> if (ret)
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER
2026-01-30 16:31 [PATCH V2] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER Chris Morgan
2026-01-31 16:36 ` Anand Moon
2026-03-03 0:49 ` Shawn Lin
@ 2026-03-04 11:24 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2026-03-04 11:24 UTC (permalink / raw)
To: Chris Morgan
Cc: linux-rockchip, linux-pm, jonas, pgwipeout, finley.xiao,
kever.yang, shawn.lin, sebastian.reichel, heiko, Chris Morgan,
Diederik de Haas
On Fri, 30 Jan 2026 at 17:33, Chris Morgan <macroalpha82@gmail.com> wrote:
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
> to prevent errors early in the boot process when the requested
> regulator is not yet available. This converts errors like the following
> to debug messages:
>
> rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Tested-by: Diederik de Haas <diederik@cknow-tech.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Changes since v1:
> - Simplified return to single line
> ---
> drivers/pmdomain/rockchip/pm-domains.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> index 997e93c12951..6d3fb18f4ab3 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -705,10 +705,9 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
> int ret;
>
> ret = rockchip_pd_regulator_enable(pd);
> - if (ret) {
> - dev_err(pd->pmu->dev, "Failed to enable supply: %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(pd->pmu->dev, ret,
> + "Failed to enable supply: %d\n", ret);
>
> ret = rockchip_pd_power(pd, true);
> if (ret)
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread