From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: dimitri.fedrau@liebherr.com, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: gpio-charger: add support for fast-charge timer
Date: Wed, 4 Feb 2026 13:44:16 +0100 [thread overview]
Message-ID: <20260204124416.GA3066@legfed1> (raw)
In-Reply-To: <aX0tJLqfY7b9oNAi@venus>
Am Fri, Jan 30, 2026 at 11:19:44PM +0100 schrieb Sebastian Reichel:
> Hi,
>
> On Fri, Jan 09, 2026 at 07:41:20PM +0100, Dimitri Fedrau via B4 Relay wrote:
> > From: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
> >
> > On some devices like TIs BQ24081 battery charger it is possible to activate
> > or deactivate a fast-charge timer that provides a backup safety for charge
> > termination. In case of the BQ24081 it is a fixed 7-hour timer. Add support
> > for enabling/disabling the fast-charge timer via GPIO.
> >
> > Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
> > ---
>
> The documentation is missing _a lot of information_. What happens
> when the fast-charge timer is disabled? What happens when it is
> enabled and times out? What do you expect users to do with this
> control knob?
>
Yes, you are right. Will add the missing information for the BQ24081.
When the timer is enabled and 7-hours are passed the device will enter
state "Timer fault" where charging is disabled and cannot be enabled
without powering the device down and up again.
Disabling the timer will just deactive the mechanism above but charging
is not affected by it.
It's just a safety feature that can be turned on/off.
Will add this information, am I missing anything else ?
Best regards,
Dimitri Fedrau
[...]
prev parent reply other threads:[~2026-02-04 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 18:41 [PATCH v2 0/2] power: supply: gpio-charger: add support for fast-charge timer Dimitri Fedrau via B4 Relay
2026-01-09 18:41 ` [PATCH v2 1/2] dt-bindings: " Dimitri Fedrau via B4 Relay
2026-01-30 22:13 ` Sebastian Reichel
2026-01-09 18:41 ` [PATCH v2 2/2] " Dimitri Fedrau via B4 Relay
2026-01-30 22:19 ` Sebastian Reichel
2026-02-04 12:44 ` Dimitri Fedrau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204124416.GA3066@legfed1 \
--to=dima.fedrau@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dimitri.fedrau@liebherr.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox