From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83AAD2032D; Sat, 7 Feb 2026 16:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770483337; cv=none; b=uFZTxQ/DdVyM4WlNWFxVH3364XUfupvUJrjfNW9o7FTxILPI9ciBG3iowQw3E2ck49MrLEj8cuxmjaOaNbmBOVxFDFs94te231oTc6HVGt6xQU50+WzdGAzeZ1tjD/awplzD8mLI+JuPqDi0n44gAgVI9N78r3iXY5VKMgwiM3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770483337; c=relaxed/simple; bh=XF9COcQaEIHxmp/l00Iy1/CqeeTFCLR4L/6pxLAwvvg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oC3AmEj9WDpJUN62xZkxmhqnF1ApiVRD6NN3YGO6HnvyZYiTbsAHSbnbPYooOCmmM2sdhwS8pOhkqucYSYStOwocTbMiMltgEl2NYgIzJvk4lz4JG/sXBGIkq39HUF2Jnzr9tvrUNZsr+UKUTZVmBSrUG4jzF1IBrWA/6tgrZpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xm/EAPH0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xm/EAPH0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FC5DC116D0; Sat, 7 Feb 2026 16:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770483337; bh=XF9COcQaEIHxmp/l00Iy1/CqeeTFCLR4L/6pxLAwvvg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Xm/EAPH0UFspdYzw4r7tfbOG5sOHicbWcvjbhhnimUgf4hWVzA4BQd6DCFteRRyRW h3Dkf06CwEtLgfm7z+mZbkYTxWX3EGeNjU4rtak2JHGiGI6XtNhmLaEti1KUjDxJga lVkgy2y57prp8QWlNpQhSx9XJc59yQzulT3dm6hJ8Xrxd5kCt4QCbqUT79gdftSwK+ jE6rn5oMuTcgrUPW22cKUJtYp5V5P45VA7rA2/lK8GD4yEhRu0wt4qTaRWUEa6SQx2 enDcFT8YH6YC8YN36fWwrbxkKTuP5ybYaZ90eg3nhYpcTZPz407Zvos2OLysvgXTg3 BBkVsfRzmJRkQ== Date: Sat, 7 Feb 2026 16:55:21 +0000 From: Jonathan Cameron To: Jishnu Prakash Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, lumag@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konradybcio@kernel.org, daniel.lezcano@linaro.org, sboyd@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, lee@kernel.org, rafael@kernel.org, subbaraman.narayanamurthy@oss.qualcomm.com, david.collins@oss.qualcomm.com, anjelique.melendez@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com, rui.zhang@intel.com, lukasz.luba@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, cros-qcom-dts-watchers@chromium.org, quic_kotarake@quicinc.com, neil.armstrong@linaro.org, stephan.gerhold@linaro.org Subject: Re: [PATCH V10 4/4] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring Message-ID: <20260207165521.357c1fb0@jic23-huawei> In-Reply-To: References: <20260130115421.2197892-1-jishnu.prakash@oss.qualcomm.com> <20260130115421.2197892-5-jishnu.prakash@oss.qualcomm.com> <20260131175412.0ded39d4@jic23-huawei> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 6 Feb 2026 18:45:22 +0530 Jishnu Prakash wrote: > Hi Jonathan, > > On 1/31/2026 11:24 PM, Jonathan Cameron wrote: > > On Fri, 30 Jan 2026 17:24:21 +0530 > > Jishnu Prakash wrote: > > > >> Add support for ADC_TM part of PMIC5 Gen3. > >> > >> This is an auxiliary driver under the Gen3 ADC driver, which implements the > >> threshold setting and interrupt generating functionalities of QCOM ADC_TM > >> drivers, used to support thermal trip points. > >> > >> Signed-off-by: Jishnu Prakash > > > > Hi Jishnu. > > > > Some minor editorial style stuff below if you are spinning again. > > Otherwise this looks good to me > > > > Reviewed-by: Jonathan Cameron > > Given I expect this patch will go through the thermal tree and not IIO. > > Just to confirm, would it be fine to keep your Reviewed-by tag in place > if I only make changes in this patch to address your comments, in the > next patch series? When you say next patch series do you mean a v11? Or a separate follow up series? We have time now as the necessary immutable branch won't be for at least 2 weeks (need rc1 to be released). Yes. You only need to drop tags if making significant changes from what was tagged. If you do drop them once given, call out why under the --- for the new patch. Jonathan >