From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166763AEF3C; Fri, 6 Mar 2026 15:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809663; cv=none; b=cUriGf4E8+wE6+n4zs4+S/e6Mx8gXEVmziJ3XGkkMs+6SpzZZhhcpeDEdAkO2ur5BwJ20JoTsgN67pwVnKEzLXC8Am8sLLlLK4gRpqSQQDVh/XEfTflRO8KrkyrIEnrF6O3RDh6QCcq5GX34NcGPPpIWI2d0RLfDzD+O2VJGgKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809663; c=relaxed/simple; bh=uHgkFtyc0A066Vp1JKuaQKpuyrLE7yGX6vBEpSKsAII=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=XQNTCe3BYc0rBGuT8RtGfx2VzsHb1ApeWAyVx6w0XWsQ+IPTAjUo1jATed3Jk8puvLJnbRWEp1Pql4bXb8CDy2jSauJLqyt887EvRHxSb1IotSF+Hb5ziechGOrc2//3nCBPwSHyZzvm4f8zLe3QxyRDHPu1xvSVlHGu/AAS2DE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DuR2+eP8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DuR2+eP8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18445C2BC87; Fri, 6 Mar 2026 15:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772809662; bh=uHgkFtyc0A066Vp1JKuaQKpuyrLE7yGX6vBEpSKsAII=; h=From:To:Cc:Subject:Date:From; b=DuR2+eP8lRGnDMxYF9ayxRAOYk/9w3OAg59BHP4YddGwXLCRWvyIvaHXyppNLLnrf DOKP5c2LGNV/ibsUcQIVHyBN7zbMaqKEfs5pSIQIfosA2y9BB6kbx/2Dj7dyjUdr0P OJ/dKjtHwvBnj/PYabXrEPV4DjE4E0ZJOd/9m0vL7dPdqyOs+b9p1Gq00bApje0TZj LeKW260hItWJF/7PWOcS2d2r25e15qhvQJLxOQS5uTecCrUC/YmiRo0hLMo2lfK3X0 VTiTMw4Ud2KTnmGsNjs4xt9tkeWf6eQOn0C2OY76xjl6JLdxo3adtVqP9UfgwmoboG yN0gcR5X/UF3g== From: Arnd Bergmann To: Sebastian Reichel , Bartosz Golaszewski , Shivendra Pratap Cc: Arnd Bergmann , =?UTF-8?q?Andr=C3=A9=20Draszik?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] power: reset: reboot-mode: fix -Wformat-security warning Date: Fri, 6 Mar 2026 16:07:34 +0100 Message-Id: <20260306150738.497978-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The device_create() function expects a format string to construct a device name, so passing a variable here introduces a possible vulnerability in case the string can contain '%' characters: drivers/power/reset/reboot-mode.c:148:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] drivers/power/reset/reboot-mode.c:148:22: note: treat the string as an argument to avoid this 148 | (void *)priv, reboot->dev->driver->name); Use an trivial "%s" format instead and pass the name as the string to be included here. Fixes: cfaf0a90789a ("power: reset: reboot-mode: Expose sysfs for registered reboot_modes") Signed-off-by: Arnd Bergmann --- drivers/power/reset/reboot-mode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot-mode.c index ad239e96774b..d20e44db0532 100644 --- a/drivers/power/reset/reboot-mode.c +++ b/drivers/power/reset/reboot-mode.c @@ -145,7 +145,8 @@ static int reboot_mode_create_device(struct reboot_mode_driver *reboot) } priv->reboot_mode_device = device_create(&reboot_mode_class, NULL, 0, - (void *)priv, reboot->dev->driver->name); + (void *)priv, "%s", + reboot->dev->driver->name); if (IS_ERR(priv->reboot_mode_device)) { ret = PTR_ERR(priv->reboot_mode_device); goto error; -- 2.39.5