From: Rosen Penev <rosenp@gmail.com>
To: linux-pm@vger.kernel.org
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-msm@vger.kernel.org (open list:QUALCOMM CORE POWER
REDUCTION (CPR) AVS DRIVER),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] pmdomain: qcom: cpr: simplify main allocation
Date: Sun, 15 Mar 2026 14:41:53 -0700 [thread overview]
Message-ID: <20260315214153.3682-1-rosenp@gmail.com> (raw)
Remove kcalloc by using a flexible array member to combine allocations.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/pmdomain/qcom/cpr.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/pmdomain/qcom/cpr.c b/drivers/pmdomain/qcom/cpr.c
index 3ee8184e4be3..c30690ef6919 100644
--- a/drivers/pmdomain/qcom/cpr.c
+++ b/drivers/pmdomain/qcom/cpr.c
@@ -239,7 +239,6 @@ struct cpr_drv {
u32 gcnt;
unsigned long flags;
- struct fuse_corner *fuse_corners;
struct corner *corners;
const struct cpr_desc *desc;
@@ -247,6 +246,8 @@ struct cpr_drv {
const struct cpr_fuse *cpr_fuses;
struct dentry *debugfs;
+
+ struct fuse_corner fuse_corners[];
};
static bool cpr_is_allowed(struct cpr_drv *drv)
@@ -1600,19 +1601,15 @@ static int cpr_probe(struct platform_device *pdev)
if (!data || !data->cpr_desc || !data->acc_desc)
return -EINVAL;
- drv = devm_kzalloc(dev, sizeof(*drv), GFP_KERNEL);
+ drv = devm_kzalloc(dev,
+ struct_size(drv, fuse_corners, data->cpr_desc->num_fuse_corners),
+ GFP_KERNEL);
if (!drv)
return -ENOMEM;
drv->dev = dev;
drv->desc = data->cpr_desc;
drv->acc_desc = data->acc_desc;
- drv->fuse_corners = devm_kcalloc(dev, drv->desc->num_fuse_corners,
- sizeof(*drv->fuse_corners),
- GFP_KERNEL);
- if (!drv->fuse_corners)
- return -ENOMEM;
-
np = of_parse_phandle(dev->of_node, "acc-syscon", 0);
if (!np)
return -ENODEV;
--
2.53.0
next reply other threads:[~2026-03-15 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 21:41 Rosen Penev [this message]
2026-03-17 11:52 ` [PATCH] pmdomain: qcom: cpr: simplify main allocation Konrad Dybcio
2026-03-18 18:22 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260315214153.3682-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox