* [chanwoo:devfreq-next 5/5] drivers/devfreq/devfreq.c:1946:37: error: redefinition of 'devfreq_group'
@ 2026-03-21 12:52 kernel test robot
2026-03-21 15:11 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-03-21 12:52 UTC (permalink / raw)
To: Jori Koolstra; +Cc: llvm, oe-kbuild-all, linux-pm, Chanwoo Choi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-next
head: 38aa14f9be920f3fea6fe3f16b69b7a0cd0478a1
commit: 38aa14f9be920f3fea6fe3f16b69b7a0cd0478a1 [5/5] PM / devfreq: change devfreq_class to a const struct
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260321/202603211336.i375F7lD-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260321/202603211336.i375F7lD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603211336.i375F7lD-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/devfreq/devfreq.c:1946:37: error: redefinition of 'devfreq_group'
1946 | static const struct attribute_group devfreq_group = {
| ^
drivers/devfreq/devfreq.c:40:1: note: previous definition is here
40 | ATTRIBUTE_GROUPS(devfreq);
| ^
include/linux/sysfs.h:291:37: note: expanded from macro 'ATTRIBUTE_GROUPS'
291 | static const struct attribute_group _name##_group = { \
| ^
<scratch space>:89:1: note: expanded from here
89 | devfreq_group
| ^
>> drivers/devfreq/devfreq.c:1955:38: error: redefinition of 'devfreq_groups'
1955 | static const struct attribute_group *devfreq_groups[] = {
| ^
drivers/devfreq/devfreq.c:40:1: note: previous definition is here
40 | ATTRIBUTE_GROUPS(devfreq);
| ^
include/linux/sysfs.h:298:11: note: expanded from macro 'ATTRIBUTE_GROUPS'
298 | }; \
| ^
include/linux/sysfs.h:285:38: note: expanded from macro '\
__ATTRIBUTE_GROUPS'
285 | static const struct attribute_group *_name##_groups[] = { \
| ^
<scratch space>:93:1: note: expanded from here
93 | devfreq_groups
| ^
2 errors generated.
vim +/devfreq_group +1946 drivers/devfreq/devfreq.c
9005b65099ee4f MyungJoo Ham 2011-10-02 1945
e4999090951abc Pengjie Zhang 2025-12-16 @1946 static const struct attribute_group devfreq_group = {
e4999090951abc Pengjie Zhang 2025-12-16 1947 .attrs = devfreq_attrs,
e4999090951abc Pengjie Zhang 2025-12-16 1948 };
e4999090951abc Pengjie Zhang 2025-12-16 1949
e4999090951abc Pengjie Zhang 2025-12-16 1950 static const struct attribute_group gov_attr_group = {
e4999090951abc Pengjie Zhang 2025-12-16 1951 .attrs = governor_attrs,
e4999090951abc Pengjie Zhang 2025-12-16 1952 .is_visible = gov_attr_visible,
e4999090951abc Pengjie Zhang 2025-12-16 1953 };
e4999090951abc Pengjie Zhang 2025-12-16 1954
e4999090951abc Pengjie Zhang 2025-12-16 @1955 static const struct attribute_group *devfreq_groups[] = {
e4999090951abc Pengjie Zhang 2025-12-16 1956 &devfreq_group,
e4999090951abc Pengjie Zhang 2025-12-16 1957 &gov_attr_group,
e4999090951abc Pengjie Zhang 2025-12-16 1958 NULL
e4999090951abc Pengjie Zhang 2025-12-16 1959 };
e4999090951abc Pengjie Zhang 2025-12-16 1960
:::::: The code at line 1946 was first introduced by commit
:::::: e4999090951abcf39543aa22b7a7a7f13c5a5857 PM / devfreq: use _visible attribute to replace create/remove_sysfs_files()
:::::: TO: Pengjie Zhang <zhangpengjie2@huawei.com>
:::::: CC: Chanwoo Choi <cw00.choi@samsung.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [chanwoo:devfreq-next 5/5] drivers/devfreq/devfreq.c:1946:37: error: redefinition of 'devfreq_group'
2026-03-21 12:52 [chanwoo:devfreq-next 5/5] drivers/devfreq/devfreq.c:1946:37: error: redefinition of 'devfreq_group' kernel test robot
@ 2026-03-21 15:11 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2026-03-21 15:11 UTC (permalink / raw)
To: kernel test robot
Cc: Jori Koolstra, llvm, oe-kbuild-all, linux-pm, Chanwoo Choi
HI Jori,
There are build errors in your patches.
DId you test it? I hope to fix and test the patch before posting.
On Sat, Mar 21, 2026 at 9:52 PM kernel test robot <lkp@intel.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-next
> head: 38aa14f9be920f3fea6fe3f16b69b7a0cd0478a1
> commit: 38aa14f9be920f3fea6fe3f16b69b7a0cd0478a1 [5/5] PM / devfreq: change devfreq_class to a const struct
> config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260321/202603211336.i375F7lD-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260321/202603211336.i375F7lD-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202603211336.i375F7lD-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> drivers/devfreq/devfreq.c:1946:37: error: redefinition of 'devfreq_group'
> 1946 | static const struct attribute_group devfreq_group = {
> | ^
> drivers/devfreq/devfreq.c:40:1: note: previous definition is here
> 40 | ATTRIBUTE_GROUPS(devfreq);
> | ^
> include/linux/sysfs.h:291:37: note: expanded from macro 'ATTRIBUTE_GROUPS'
> 291 | static const struct attribute_group _name##_group = { \
> | ^
> <scratch space>:89:1: note: expanded from here
> 89 | devfreq_group
> | ^
> >> drivers/devfreq/devfreq.c:1955:38: error: redefinition of 'devfreq_groups'
> 1955 | static const struct attribute_group *devfreq_groups[] = {
> | ^
> drivers/devfreq/devfreq.c:40:1: note: previous definition is here
> 40 | ATTRIBUTE_GROUPS(devfreq);
> | ^
> include/linux/sysfs.h:298:11: note: expanded from macro 'ATTRIBUTE_GROUPS'
> 298 | }; \
> | ^
> include/linux/sysfs.h:285:38: note: expanded from macro '\
> __ATTRIBUTE_GROUPS'
> 285 | static const struct attribute_group *_name##_groups[] = { \
> | ^
> <scratch space>:93:1: note: expanded from here
> 93 | devfreq_groups
> | ^
> 2 errors generated.
>
>
> vim +/devfreq_group +1946 drivers/devfreq/devfreq.c
>
> 9005b65099ee4f MyungJoo Ham 2011-10-02 1945
> e4999090951abc Pengjie Zhang 2025-12-16 @1946 static const struct attribute_group devfreq_group = {
> e4999090951abc Pengjie Zhang 2025-12-16 1947 .attrs = devfreq_attrs,
> e4999090951abc Pengjie Zhang 2025-12-16 1948 };
> e4999090951abc Pengjie Zhang 2025-12-16 1949
> e4999090951abc Pengjie Zhang 2025-12-16 1950 static const struct attribute_group gov_attr_group = {
> e4999090951abc Pengjie Zhang 2025-12-16 1951 .attrs = governor_attrs,
> e4999090951abc Pengjie Zhang 2025-12-16 1952 .is_visible = gov_attr_visible,
> e4999090951abc Pengjie Zhang 2025-12-16 1953 };
> e4999090951abc Pengjie Zhang 2025-12-16 1954
> e4999090951abc Pengjie Zhang 2025-12-16 @1955 static const struct attribute_group *devfreq_groups[] = {
> e4999090951abc Pengjie Zhang 2025-12-16 1956 &devfreq_group,
> e4999090951abc Pengjie Zhang 2025-12-16 1957 &gov_attr_group,
> e4999090951abc Pengjie Zhang 2025-12-16 1958 NULL
> e4999090951abc Pengjie Zhang 2025-12-16 1959 };
> e4999090951abc Pengjie Zhang 2025-12-16 1960
>
> :::::: The code at line 1946 was first introduced by commit
> :::::: e4999090951abcf39543aa22b7a7a7f13c5a5857 PM / devfreq: use _visible attribute to replace create/remove_sysfs_files()
>
> :::::: TO: Pengjie Zhang <zhangpengjie2@huawei.com>
> :::::: CC: Chanwoo Choi <cw00.choi@samsung.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-21 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-21 12:52 [chanwoo:devfreq-next 5/5] drivers/devfreq/devfreq.c:1946:37: error: redefinition of 'devfreq_group' kernel test robot
2026-03-21 15:11 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox