From: aravindanilraj0702@gmail.com
To: rafael@kernel.org, linux-pm@vger.kernel.org
Cc: daniel.lezcano@kernel.org, rui.zhang@intel.com,
lukasz.luba@arm.com, srinivas.pandruvada@linux.intel.com,
linux-kernel@vger.kernel.org,
Aravind Anilraj <aravindanilraj0702@gmail.com>
Subject: [PATCH 1/2] thermal: intel: int340x: Fix potential shift overflow in ptc_mmio_write
Date: Sat, 28 Mar 2026 15:18:05 -0400 [thread overview]
Message-ID: <20260328191806.8675-2-aravindanilraj0702@gmail.com> (raw)
In-Reply-To: <20260328191806.8675-1-aravindanilraj0702@gmail.com>
From: Aravind Anilraj <aravindanilraj0702@gmail.com>
The value parameter is u32 but is shifted into a u64 register value
without casting first. If the shift amount pushes bits beyond 32, they
are lost. Cast value to u64 before shifting to ensure all bits are
preserved.
Signed-off-by: Aravind Anilraj <aravindanilraj0702@gmail.com>
---
.../intel/int340x_thermal/platform_temperature_control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c b/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c
index 0ccc72c93499..18ac5014d8dc 100644
--- a/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c
+++ b/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c
@@ -138,7 +138,7 @@ static void ptc_mmio_write(struct pci_dev *pdev, u32 offset, int index, u32 valu
reg_val = readq((void __iomem *) (proc_priv->mmio_base + offset));
reg_val &= ~mask;
- reg_val |= (value << ptc_mmio_regs[index].shift);
+ reg_val |= ((u64)value << ptc_mmio_regs[index].shift);
writeq(reg_val, (void __iomem *) (proc_priv->mmio_base + offset));
}
--
2.47.3
next prev parent reply other threads:[~2026-03-28 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 19:18 [PATCH 0/2] thermal: intel: int340x: Fix bugs in aravindanilraj0702
2026-03-28 19:18 ` aravindanilraj0702 [this message]
2026-03-28 19:18 ` [PATCH 2/2] thermal: intel: int340x: Check return value of ptc_create_groups() aravindanilraj0702
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260328191806.8675-2-aravindanilraj0702@gmail.com \
--to=aravindanilraj0702@gmail.com \
--cc=daniel.lezcano@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox