public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Haowen Tu <tuhaowen@uniontech.com>
To: oneukum@suse.com
Cc: hansg@kernel.org, laurent.pinchart@ideasonboard.com,
	lenb@kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-pm@vger.kernel.org,
	mchehab@kernel.org, pavel@kernel.org, rafael@kernel.org,
	tuhaowen@uniontech.com
Subject: Re: [PATCH 2/2] media: uvcvideo: skip resume when writing hibernation image
Date: Tue, 28 Apr 2026 16:58:59 +0800	[thread overview]
Message-ID: <20260428085859.1840613-1-tuhaowen@uniontech.com> (raw)
In-Reply-To: <937aca8d-805b-418e-a2ed-58c1e38f45e7@suse.com>

Hi Oliver,

On Tue, 28 Apr 2026, Oliver Neukum wrote:
> What happens if writing out the image fails?

Thanks for pointing this out.

If swsusp_write() fails, the system resumes in the original kernel
instead of powering off, so the failure path needs to be considered as
well. I was reasoning about the successful hibernation path here, but
you are right that skipping resume work during THAW may not be safe if
the image write does not complete.

I will trace the failure path more carefully and update the series
accordingly.

Thanks,
Haowen Tu

  reply	other threads:[~2026-04-28  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  8:05 [PATCH 0/2] PM: hibernate: add helper to detect image-write phase Haowen Tu
2026-04-28  8:05 ` [PATCH 1/2] PM: hibernate: add pm_hibernation_storing_image() helper Haowen Tu
2026-04-28  8:05 ` [PATCH 2/2] media: uvcvideo: skip resume when writing hibernation image Haowen Tu
2026-04-28  8:36   ` Oliver Neukum
2026-04-28  8:58     ` Haowen Tu [this message]
2026-04-28  9:13   ` Laurent Pinchart
2026-04-29  1:15     ` Haowen Tu
2026-04-29  1:16     ` Haowen Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428085859.1840613-1-tuhaowen@uniontech.com \
    --to=tuhaowen@uniontech.com \
    --cc=hansg@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=oneukum@suse.com \
    --cc=pavel@kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox