From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D450480DCD; Tue, 5 May 2026 15:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777993548; cv=none; b=aL+G8LyouKPuXuyBrFrBeNOccdDLkrrLU8cDowu4THsi0ocZcIGca57gfROqBb55qdQ8yFKF7guLEsKKcv1z/1izp0/agSdozouGRlnd+wv+YJMWbBalpjzhfBI34l5/qiHmoemO7rqXvvpMto6BBDVunET5pDEjNLyRVK8eawY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777993548; c=relaxed/simple; bh=fjhctLjrzP8ABWybAS9/Xz+fkBSmi6e/VKPohchYNGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=khclFOPjhhMNyyBC/aW65FFbGyTCxdKzzw+NnWdYKN2K+7kZHPc1Q9BKC1hPnbiHoglFihxgtJKF3zM1nq6zmRc6/rnjgc+aJ2x+OZJpb7AqW28lsqcIzUp1cxNeNtkuR9O3whO7KAcOmdhpGFLu/cusudIIzktRPV9IF+UcHdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DldJROvJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DldJROvJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FAE2C2BCC7; Tue, 5 May 2026 15:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777993547; bh=fjhctLjrzP8ABWybAS9/Xz+fkBSmi6e/VKPohchYNGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DldJROvJl+GnItu11wN0UY1H6kpVglyyugjbuNb0x52JurAYJp3+RIldpVzIMIpDH 3UjyLAJ9kK1WNvj3gSQRs3BnPKMtVMdw/w90NVfsApy1YWCtUFAPVxGwQ3YDYGdpt5 UIrav3YWYVCyZv7zW8B2l2uT0XPCZmoqAiHxn9gQMH3Kf+gH++H+nyUfbG+58tXsFK NcQBpoqwfWIw1c7gT36EjY2QkTAwdEHgq1T/Y5KbgzazK7Q7b8NQPPIlrahhBkUOAu nkD4JblRwUB+x3kManmAZCtgsYqpt4mYTuvxQ3I0ML9cSjyeSRp3zr9A9W0gOhNf5W a0cfPTqAE3G+w== Date: Tue, 5 May 2026 16:05:38 +0100 From: Lee Jones To: Bartosz Golaszewski Cc: Shivendra Pratap , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , Srinivas Kandagatla , Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Sudeep Holla Subject: Re: [PATCH v21 08/13] mfd: core: Add firmware-node support to MFD cells Message-ID: <20260505150538.GE2661693@google.com> References: <20260427-arm-psci-system_reset2-vendor-reboots-v21-0-dcf937775e73@oss.qualcomm.com> <20260427-arm-psci-system_reset2-vendor-reboots-v21-8-dcf937775e73@oss.qualcomm.com> <37ab0178-1c9d-409e-bbaa-832f8075afa4@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, 30 Apr 2026, Bartosz Golaszewski wrote: > On Wed, Apr 29, 2026 at 6:10 PM Shivendra Pratap > wrote: > > > > > > > > On 29-04-2026 15:20, Bartosz Golaszewski wrote: > > > On Wed, Apr 29, 2026 at 11:46 AM Shivendra Pratap > > > wrote: > > >> > > >>>> > > >>>> If set, it would be called from MFD core and would do the name lookup > > >>>> and return the fwnode which would then be assigned to the cell device? > > >>> > > >> > > >> Or should we just drop this patch for fwnode in mfd-core? > > >> > > >> Export a new call in reboot-mode framework as: > > >> reboot_mode_register_node(struct reboot_mode_driver *reboot, > > >> struct device_node *np / fwnode) > > >> > > >> Use the parent node in psci-reboot-mode and find reboot-mode and call > > >> reboot_mode_register_node? > > >> > > > > > > No, I think the reboot-mode device (as pointed to by the dev field of > > > struct reboot_mode_driver) should be associated with the right fwnode > > > from the start so it should be handled in MFD core. > > > > Ack. something like should be fine? > > > > drivers/mfd/mfd-core.c : > > + if (!pdev->dev.fwnode && cell->get_fwnode) { > > + fwnode = cell->get_fwnode(parent); > > + if (fwnode) > > + device_set_node(&pdev->dev, fwnode); > > + } > > > > Possibly we could find a better name, but yeah the general idea is sound. > > Of course, let's maybe here from Lee if he's ok before sending a new version. Send away - I'll review in the context of the whole submission. -- Lee Jones