From: kernel test robot <lkp@intel.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Kaushlendra Kumar <kaushlendra.kumar@intel.com>,
Kees Cook <kees@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, pengpeng@iscas.ac.cn
Subject: Re: [PATCH] thermal: intel: int3400: clean up ODVP on probe failures
Date: Mon, 15 Jun 2026 20:25:42 +0800 [thread overview]
Message-ID: <202606152042.8kTVDHYg-lkp@intel.com> (raw)
In-Reply-To: <20260615070326.71761-1-pengpeng@iscas.ac.cn>
Hi Pengpeng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v7.1 next-20260612]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pengpeng-Hou/thermal-intel-int3400-clean-up-ODVP-on-probe-failures/20260615-152757
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link: https://lore.kernel.org/r/20260615070326.71761-1-pengpeng%40iscas.ac.cn
patch subject: [PATCH] thermal: intel: int3400: clean up ODVP on probe failures
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260615/202606152042.8kTVDHYg-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260615/202606152042.8kTVDHYg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606152042.8kTVDHYg-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/thermal/intel/int340x_thermal/int3400_thermal.c: In function 'int3400_thermal_probe':
>> drivers/thermal/intel/int340x_thermal/int3400_thermal.c:659:1: warning: label 'free_art_trt' defined but not used [-Wunused-label]
659 | free_art_trt:
| ^~~~~~~~~~~~
>> drivers/thermal/intel/int340x_thermal/int3400_thermal.c:651:1: warning: label 'free_imok' defined but not used [-Wunused-label]
651 | free_imok:
| ^~~~~~~~~
vim +/free_art_trt +659 drivers/thermal/intel/int340x_thermal/int3400_thermal.c
0ba13c763aacb2 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 556
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 557 static int int3400_thermal_probe(struct platform_device *pdev)
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 558 {
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 559 struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 560 struct int3400_thermal_priv *priv;
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 561 int result;
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 562
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 563 if (!adev)
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 564 return -ENODEV;
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 565
bf4afc53b77aea drivers/thermal/intel/int340x_thermal/int3400_thermal.c Linus Torvalds 2026-02-21 566 priv = kzalloc_obj(*priv);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 567 if (!priv)
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 568 return -ENOMEM;
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 569
006f006f1e5c48 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 570 priv->pdev = pdev;
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 571 priv->adev = adev;
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 572
c5738dddc01be4 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 573 result = int3400_thermal_get_uuids(priv);
8d485da0ddee79 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 574
8d485da0ddee79 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 575 /* Missing IDSP isn't fatal */
8d485da0ddee79 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 576 if (result && result != -ENODEV)
c5738dddc01be4 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 577 goto free_priv;
c5738dddc01be4 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 578
8d485da0ddee79 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 579 priv->current_uuid_index = -1;
8d485da0ddee79 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 580
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 581 result = acpi_parse_art(priv->adev->handle, &priv->art_count,
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 582 &priv->arts, true);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 583 if (result)
f126079123f9d0 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2015-02-25 584 dev_dbg(&pdev->dev, "_ART table parsing error\n");
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 585
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 586 result = acpi_parse_trt(priv->adev->handle, &priv->trt_count,
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 587 &priv->trts, true);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 588 if (result)
f126079123f9d0 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2015-02-25 589 dev_dbg(&pdev->dev, "_TRT table parsing error\n");
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 590
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 591 platform_set_drvdata(pdev, priv);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 592
0ba13c763aacb2 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 593 int3400_setup_gddv(priv);
0ba13c763aacb2 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 594
006f006f1e5c48 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 595 evaluate_odvp(priv);
006f006f1e5c48 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 596
cbcd51e822bf51 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Rafael J. Wysocki 2023-08-30 597 priv->thermal = thermal_tripless_zone_device_register("INT3400 Thermal", priv,
cbcd51e822bf51 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Rafael J. Wysocki 2023-08-30 598 &int3400_thermal_ops,
cbcd51e822bf51 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Rafael J. Wysocki 2023-08-30 599 &int3400_thermal_params);
0ab15365ff38c8 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 600 if (IS_ERR(priv->thermal)) {
0ab15365ff38c8 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 601 result = PTR_ERR(priv->thermal);
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 602 goto free_odvp;
0ab15365ff38c8 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 603 }
0ab15365ff38c8 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 604
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 605 priv->rel_misc_dev_res = acpi_thermal_rel_misc_device_add(
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 606 priv->adev->handle);
6306e68a63f262 drivers/thermal/int340x_thermal/int3400_thermal.c Jacob Pan 2014-06-12 607
19ecaea2686222 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2014-12-02 608 result = sysfs_create_group(&pdev->dev.kobj, &uuid_attribute_group);
19ecaea2686222 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2014-12-02 609 if (result)
0be86969ae385c drivers/thermal/int340x_thermal/int3400_thermal.c Alexey Khoroshilov 2017-12-30 610 goto free_rel_misc;
19ecaea2686222 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2014-12-02 611
f1b07a14694be0 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Sumeet Pawnikar 2021-07-16 612 if (acpi_has_method(priv->adev->handle, "IMOK")) {
f1b07a14694be0 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Sumeet Pawnikar 2021-07-16 613 result = sysfs_create_group(&pdev->dev.kobj, &imok_attribute_group);
f1b07a14694be0 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Sumeet Pawnikar 2021-07-16 614 if (result)
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 615 goto free_uuid;
f1b07a14694be0 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Sumeet Pawnikar 2021-07-16 616 }
f1b07a14694be0 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Sumeet Pawnikar 2021-07-16 617
7931e28098a4c1 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Lee, Chun-Yi 2022-08-08 618 if (!ZERO_OR_NULL_PTR(priv->data_vault)) {
13f3cbfbb8c9f3 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Thomas Weißschuh 2024-11-21 619 result = device_create_bin_file(&pdev->dev, &bin_attr_data_vault);
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 620 if (result) {
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 621 kfree(priv->data_vault);
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 622 priv->data_vault = NULL;
0ba13c763aacb2 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 623 goto free_uuid;
0ba13c763aacb2 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 624 }
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 625 }
0ba13c763aacb2 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 626
38e44da591303d drivers/thermal/int340x_thermal/int3400_thermal.c Brian Bian 2017-08-09 627 result = acpi_install_notify_handler(
38e44da591303d drivers/thermal/int340x_thermal/int3400_thermal.c Brian Bian 2017-08-09 628 priv->adev->handle, ACPI_DEVICE_NOTIFY, int3400_notify,
38e44da591303d drivers/thermal/int340x_thermal/int3400_thermal.c Brian Bian 2017-08-09 629 (void *)priv);
38e44da591303d drivers/thermal/int340x_thermal/int3400_thermal.c Brian Bian 2017-08-09 630 if (result)
0be86969ae385c drivers/thermal/int340x_thermal/int3400_thermal.c Alexey Khoroshilov 2017-12-30 631 goto free_sysfs;
38e44da591303d drivers/thermal/int340x_thermal/int3400_thermal.c Brian Bian 2017-08-09 632
5c36cf27846a36 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2023-01-23 633 result = production_mode_init(priv);
5c36cf27846a36 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2023-01-23 634 if (result)
5c36cf27846a36 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2023-01-23 635 goto free_notify;
5c36cf27846a36 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2023-01-23 636
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 637 return 0;
19ecaea2686222 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2014-12-02 638
5c36cf27846a36 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2023-01-23 639 free_notify:
5c36cf27846a36 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2023-01-23 640 acpi_remove_notify_handler(priv->adev->handle, ACPI_DEVICE_NOTIFY,
5c36cf27846a36 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2023-01-23 641 int3400_notify);
0be86969ae385c drivers/thermal/int340x_thermal/int3400_thermal.c Alexey Khoroshilov 2017-12-30 642 free_sysfs:
006f006f1e5c48 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 643 cleanup_odvp(priv);
e9a7c526c29b0a drivers/thermal/intel/int340x_thermal/int3400_thermal.c Rafael J. Wysocki 2022-08-30 644 if (!ZERO_OR_NULL_PTR(priv->data_vault)) {
13f3cbfbb8c9f3 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Thomas Weißschuh 2024-11-21 645 device_remove_bin_file(&pdev->dev, &bin_attr_data_vault);
006f006f1e5c48 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 646 kfree(priv->data_vault);
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 647 priv->data_vault = NULL;
006f006f1e5c48 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 648 }
0ba13c763aacb2 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Matthew Garrett 2020-04-13 649 free_uuid:
0be86969ae385c drivers/thermal/int340x_thermal/int3400_thermal.c Alexey Khoroshilov 2017-12-30 650 sysfs_remove_group(&pdev->dev.kobj, &uuid_attribute_group);
f1b07a14694be0 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Sumeet Pawnikar 2021-07-16 @651 free_imok:
f1b07a14694be0 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Sumeet Pawnikar 2021-07-16 652 sysfs_remove_group(&pdev->dev.kobj, &imok_attribute_group);
0be86969ae385c drivers/thermal/int340x_thermal/int3400_thermal.c Alexey Khoroshilov 2017-12-30 653 free_rel_misc:
0be86969ae385c drivers/thermal/int340x_thermal/int3400_thermal.c Alexey Khoroshilov 2017-12-30 654 if (!priv->rel_misc_dev_res)
0be86969ae385c drivers/thermal/int340x_thermal/int3400_thermal.c Alexey Khoroshilov 2017-12-30 655 acpi_thermal_rel_misc_device_remove(priv->adev->handle);
19ecaea2686222 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2014-12-02 656 thermal_zone_device_unregister(priv->thermal);
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 657 free_odvp:
19f67ce6d353c4 drivers/thermal/intel/int340x_thermal/int3400_thermal.c Pengpeng Hou 2026-06-15 658 cleanup_odvp(priv);
f126079123f9d0 drivers/thermal/int340x_thermal/int3400_thermal.c Srinivas Pandruvada 2015-02-25 @659 free_art_trt:
0ab15365ff38c8 drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-23 660 kfree(priv->trts);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 661 kfree(priv->arts);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 662 free_priv:
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 663 kfree(priv);
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 664 return result;
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 665 }
816cab931f288c drivers/thermal/int340x_thermal/int3400_thermal.c Zhang Rui 2014-03-14 666
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-06-15 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 7:03 [PATCH] thermal: intel: int3400: clean up ODVP on probe failures Pengpeng Hou
2026-06-15 12:25 ` kernel test robot [this message]
2026-06-15 14:13 ` kernel test robot
2026-06-15 14:24 ` kernel test robot
2026-06-15 15:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606152042.8kTVDHYg-lkp@intel.com \
--to=lkp@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@kernel.org \
--cc=kaushlendra.kumar@intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pengpeng@iscas.ac.cn \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox