From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67177374E45 for ; Mon, 6 Jul 2026 13:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342815; cv=none; b=jYgbgtN53TQoOEAtNY2p09h2t0C6n0tApvE9YulkWXnJHW0ltm271fuWLFy7JJ3FJhWUwwWtJFuPtxKn6DKHXa3KIY7VXguHVnj0nvaC+shqgxBTQqkGwlwxs6imz+Hms6u2IxkiFbx6CAO/hMBKesXYsaLP/w86WuFfV0WGU3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342815; c=relaxed/simple; bh=IqF/4dKgB1628r62VJTRc6pv/7HE6yY73nomq/D91IU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DbUFlVAvl0DQBI53Fxhvd9GQr6yT+Dw3TMZCmjdEYao/pXvC6jmBkQX7N87VjDbj2lXucOvMqhUj1cMuimGD/ch1ZNc5l/8W0nL4v+FPvgyeFYnCgHZ6RW84/qr8acV1CDeD5+WDXji8vvo5N2Kp48hCR7rK1uegdvRDvwNt1Sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mJEEF2hq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LSjOwm1p; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mJEEF2hq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LSjOwm1p" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax9n5391056 for ; Mon, 6 Jul 2026 12:45:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j94N3D67YZmp+yB/bJ2N7wl2Db8ez4ZkEgubeH9mxnM=; b=mJEEF2hqlR/uOjVJ VGxfq6X8Coeflz9gG17PG5AS1d8bsHMFXhdZWsQVpoBGNxPvBhyMKeuA+dyOCDVQ f1hfsjqCoXOdNFPJoAu72h5EhTA2RJe8aHAuVR3do6hcY/6XuWdPi5v4ABh+SBK/ rcNeX0qyntCP4cdXULNVaYmo+GOzB4IXw/vS1gy2FdSZK/epGthEs0eICwD0JDHC qLwA7MiAX+whloAu+BOq3pVZA9mRrwwWNHrvcFQktC3WPAB1dKapRcEh1XLp4aGO t0DPDKiFYVlnUQvHVG/TurGAk+efJV3NTROGxUtnqQUlu+PHgMshaUYjPMuJ3IBZ RMPGMA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgrrmk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 12:45:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e695a3b28so387916585a.1 for ; Mon, 06 Jul 2026 05:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783341952; x=1783946752; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j94N3D67YZmp+yB/bJ2N7wl2Db8ez4ZkEgubeH9mxnM=; b=LSjOwm1pQbd2IbAtQs3jb6I9Wx4eddLfL/U4gCa1mM/zhtJY4PeZXUDBFhTonpWBgP OCT10pOrC91EUmeqX5GrSxLRFPwp+aQASAhIw9p4VtV+ZpTHkDofML4/IQgFMsC4b3kM 9Zjo4qmMrIrcNSwVLU7dNIeGw6NGr54JWuBZ66MTyNfwZ7AtKp/RlfMWK3rfaqBTrAwN NO8NsEeMdHySf1WMJYOCkuN/EliXX91PTc9wjK3Bq6A+D3lN74H0H5vsPggEqQg2V/bK SsuP1hokyxHnnTdu6y42Zz91sMgOXgXlrBsuWwXQ3/Sr3lBxkAelRACjGtxaGV6W5A98 m4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783341952; x=1783946752; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j94N3D67YZmp+yB/bJ2N7wl2Db8ez4ZkEgubeH9mxnM=; b=KzlrRh0mjerLokwm64z3ln2vN6IRXkgUnVWga+6rg5EmDHiZkLVuN55ALsh5qu3BYC c/DV2pm1biTEIA2UwDw9vUKeh9XnJ0eHpk9dzXZtU9fPeymyEIH4qByvTfqS6nim7GPV BydoliD4E8/25KuS4l+cezMEvb11h6DeEEzthwmZO/CDldJqmh+pbB4kO549g6FAKv+b X5qmXYdEvye5IdXaya9F/5jZa2GrmKUb0cxSksneLH+HVBku6cDLM4YKYq3fdvrcXaey VAfu83iTia2EEAtmXKTZx43zXj6leoSlDlzmLJkGaqFaOfQJAPwEdfwN7TE/zbkbCkzr JjTA== X-Forwarded-Encrypted: i=1; AHgh+RqUjbKNeR5arejl6i0VemjOedDp0JMlTRL029HT0adEdbxHYXyOETB7xg3Nx8AMY8+YnwPOvVuIPQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yy0CHgeCuCbPvtrCZ34Wgt8ATGcGqkGRRWvPXCj6vTzgMokxu2f 3QvKMQVhH5gcEGV4fV63XKY4FCYt0ejMMNYz/suZkdTIFnZCgdt/BAFHiu4Vipo69JHADefhrUr IPPSf+FT6VGZk2oOkf3gE7IpGWSMxU4PQmKhuJkzkD+SwL8OvgtGmIpb7O1CBBg== X-Gm-Gg: AfdE7clhBbdAh8MR9d7tQlPmuvq0283ceASX0NHAQK8BPoOCpnobrkIOBjhvzfjOHis 0aHl4qSkOOTdv68B61u0tSrIhHf99cMp2fdPPlxBeUXbQNDVCZhY+n7vbKvhgQ1f01pkQGu0ag1 dIenLIXQ0ANnWegoOszLddW1GtTDNFNAoscVLwaz9WBkU/wTuae5AJGCjKdHLvAnX8Ub96Lnckd M9GdM7lKfS4oBKmAKf1tYXOnZQdUc8llIgLbf9wxf8hkBISaWsuYC6y5l+BfbukuCcfxkicX28f 20sH89Wpj8EGFn0PRyhs6UgyBJojK6gP6HfOmrJbEeewlgFI6rZNA6gyPtx3ODNJ8HYLxpJ/T1A VgPka1Q+svj/KfQEYLvldhCyKrR0vBbjUznPVVk4N X-Received: by 2002:a05:620a:459f:b0:92e:5b63:224e with SMTP id af79cd13be357-92e8b5049abmr1749183685a.22.1783341951105; Mon, 06 Jul 2026 05:45:51 -0700 (PDT) X-Received: by 2002:a05:620a:459f:b0:92e:5b63:224e with SMTP id af79cd13be357-92e8b5049abmr1749171985a.22.1783341950261; Mon, 06 Jul 2026 05:45:50 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:86f0:c42b:ef4c:d3bb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0a55be4sm22126539f8f.31.2026.07.06.05.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 05:45:49 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 06 Jul 2026 14:44:32 +0200 Subject: [PATCH v3 20/20] driver core: platform: count references to all kinds of firmware nodes Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260706-pdev-fwnode-ref-v3-20-1ff028e33779@oss.qualcomm.com> References: <20260706-pdev-fwnode-ref-v3-0-1ff028e33779@oss.qualcomm.com> In-Reply-To: <20260706-pdev-fwnode-ref-v3-0-1ff028e33779@oss.qualcomm.com> To: Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Andy Shevchenko , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt Cc: brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org, mfd@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2537; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=IqF/4dKgB1628r62VJTRc6pv/7HE6yY73nomq/D91IU=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqS6M9ruJ8yyUk+I6pdpFWbcAtYm5CgsYvefKU+ TywqoMuS8KJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCakujPQAKCRAFnS7L/zaE w0+BD/9zjT3fKJr7/zYP0sHpUApNtRCsyLsJzRKuAlcO+cogBO21GRQk1DGikSTFqOqALVvaQ2g 83j83HjHg+bMyaUlGN/FEHSMVHmKvXmesanFWRUyj5q/cQcFMH8POK0Xe3edFHZZx4BBkdJLCiU YBgV2p9qKU7Yx9ujTc0nbFflTLCPc+KLCa6XMeNIL7NcRgHVvMgBJocHY4ppEVSl3w0N1MqzNLN MJ2jEc+08OGTNE6VqBsWKGpcVcsy0c/flgXequGSLwF2lbMvrEVBeckaXblcohUFBgsZTwHIilr DuAyyAxwT3CWTsisqCJ/uzziDpBphBHYSMVHgzJR0EvF/dg0gFk2JrYTFDjipwiMhwshuY4pMG6 brBELDRVNzWmoJxvrqtCNEs2g6/282jmP5bq8VSGXsiFh0Tlh1WMQesFTI3Dru/rc0SNeU4rkul wq2awNwyKdDtNJtZDmRz22Vrcbh76dcF1Halbc2omaKC8QdnXDZFTtncn03dXnNqBcF2/RucoRD PgoRvdtJOI/EakLR/ayb7hAHHB2aey6mLr7a280QfJRvxTxQ9lcDY4ZxG2oeQyo5EJpmBhQCPl8 BmnHyLd2X+djvXjF8tGCWMjxCty1aDjcqXp8ApTdwR04CWKI/ZYVFf+bcapravEbsUypfWAAx2W 0i3DMYG/6NOmHjA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: k5Tg8xDkmIL3h1JKiDGpgUG9O6ytuPeT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDEyOSBTYWx0ZWRfX1oOetvjcUJ/Q OtXg74SzIoVdStZQ7EPwJZIHF4RpI8o+SmuPHjf85vqtsgxT7Mvkp9MQWvabapJ+nMkTpZ55ABX 7iKUdbwrehHMtJezVjQZMH4uxp2hyXDgtc4o458gusefmFuPwLrqPT8yH/B9spFpfNgwEipxfjq ELLLNxF5CIp1492THlGXhyBYMNr1j8aKznUGsJifAS8hq1X+kStufALG6qNby8iGUW65I8yeOQ7 2j6rDmDKx673xweEUjbqin9BHu3IHC6s+KAlZNPU+P4+WNvZpSdC+1GhvpzCNpGaldLSpJkOZyt cC7v/fJAaOfxA3kFbjB58qfD/spSiDkZO8pFwCY40McqZB35m8zWTW8sb4WFmtPug65ZV6SENHg MlzeW2r8M/fUFsqufQH6ffXMd/Qi4FOlkh8lkMbcwd48jJRaFUShOQN/2W8QOgIDQA0cluHjLap YSo9KAhtoMfvbtKAl6Q== X-Proofpoint-ORIG-GUID: k5Tg8xDkmIL3h1JKiDGpgUG9O6ytuPeT X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDEyOSBTYWx0ZWRfXyAsqVY7COGLc d2fVQ79SImv68Uum44qIndWqHgcApi/tsrNZrhv03CutOpLmVJPnYoURY78BlTv9smOKD/QT0Rs 7fjwLX5QBC521Xlb96o3rYgzdKTrzmM= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4ba380 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=2sGp0kyKjRk1obZUzdUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060129 When using platform_device_register_full(), we currently only increase the reference count of the OF node associated with a platform device. We symmetrically decrease it in platform_device_release(). With all users in tree now converted to using provided platform device helpers for assigning OF and firmware nodes, we can now switch to counting references of all kinds of firmware nodes. Reviewed-by: Andy Shevchenko Signed-off-by: Bartosz Golaszewski --- drivers/base/platform.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 9357942d0c79b032645035879b2bed3d53305b9f..a71015f1d915340aa01ebfae67196d4d7ccecba8 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -599,7 +599,7 @@ static void platform_device_release(struct device *dev) struct platform_object *pa = container_of(dev, struct platform_object, pdev.dev); - of_node_put(pa->pdev.dev.of_node); + fwnode_handle_put(pa->pdev.dev.fwnode); kfree(pa->pdev.dev.platform_data); kfree(pa->pdev.mfd_cell); kfree(pa->pdev.resource); @@ -712,9 +712,7 @@ EXPORT_SYMBOL_GPL(platform_device_add_data); void platform_device_set_of_node(struct platform_device *pdev, struct device_node *np) { - of_node_put(pdev->dev.of_node); - pdev->dev.of_node = of_node_get(np); - pdev->dev.fwnode = of_fwnode_handle(np); + platform_device_set_fwnode(pdev, of_fwnode_handle(np)); } EXPORT_SYMBOL_GPL(platform_device_set_of_node); @@ -730,10 +728,8 @@ EXPORT_SYMBOL_GPL(platform_device_set_of_node); void platform_device_set_fwnode(struct platform_device *pdev, struct fwnode_handle *fwnode) { - if (is_of_node(fwnode)) - platform_device_set_of_node(pdev, to_of_node(fwnode)); - else - pdev->dev.fwnode = fwnode; + fwnode_handle_put(pdev->dev.fwnode); + device_set_node(&pdev->dev, fwnode_handle_get(fwnode)); } EXPORT_SYMBOL_GPL(platform_device_set_fwnode); @@ -928,8 +924,7 @@ struct platform_device *platform_device_register_full(const struct platform_devi return ERR_PTR(-ENOMEM); pdev->dev.parent = pdevinfo->parent; - pdev->dev.fwnode = pdevinfo->fwnode; - pdev->dev.of_node = of_node_get(to_of_node(pdev->dev.fwnode)); + device_set_node(&pdev->dev, fwnode_handle_get(pdevinfo->fwnode)); dev_assign_of_node_reused(&pdev->dev, pdevinfo->of_node_reused); if (pdevinfo->dma_mask) { -- 2.47.3