From: Borislav Petkov <bp@alien8.de>
To: Jason Andryuk <jason.andryuk@amd.com>
Cc: Rong Zhang <i@rong.moe>,
Mario Limonciello <mario.limonciello@amd.com>,
Huang Rui <ray.huang@amd.com>, Perry Yuan <perry.yuan@amd.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH] cpufreq/amd-pstate: Bail out early in virtual machines and don't warn
Date: Wed, 15 Jul 2026 15:58:34 -0700 [thread overview]
Message-ID: <20260715225834.GAalgQmpfnioYepdbz@fat_crate.local> (raw)
In-Reply-To: <61a141cd-c72a-4ee5-8273-ee721aa13f68@amd.com>
On Wed, Jul 15, 2026 at 04:32:53PM -0400, Jason Andryuk wrote:
> I think changing amd_cppc_supported() to return false for
> X86_FEATURE_HYPERVISOR makes sense and can remove the message. The
> heuristic there doesn't seem relevant when virtualized.
I don't maintain that code but if I were, I won't sprinkle if
X86_FEATURE_HYPERVISOR for no good reason. And the guest warning is not good
enough a reason.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-07-15 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 17:41 [PATCH] cpufreq/amd-pstate: Bail out early in virtual machines and don't warn Rong Zhang
2026-07-15 17:46 ` Mario Limonciello
2026-07-15 18:04 ` Borislav Petkov
2026-07-15 19:21 ` Rong Zhang
2026-07-15 20:32 ` Jason Andryuk
2026-07-15 20:54 ` Mario Limonciello
2026-07-15 22:58 ` Borislav Petkov [this message]
2026-07-16 17:44 ` Michael Kelley
2026-07-16 18:00 ` K Prateek Nayak
2026-07-16 18:29 ` Rong Zhang
2026-07-16 18:58 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715225834.GAalgQmpfnioYepdbz@fat_crate.local \
--to=bp@alien8.de \
--cc=i@rong.moe \
--cc=jason.andryuk@amd.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox