From: Pan Chuang <panchuang@vivo.com>
To: Walker Chen <walker.chen@starfivetech.com>,
Changhuang Liang <changhuang.liang@starfivetech.com>,
Ulf Hansson <ulfh@kernel.org>,
linux-pm@vger.kernel.org (open list:GENERIC PM DOMAINS),
linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH] pmdomain: starfive: Remove redundant dev_err()
Date: Thu, 16 Jul 2026 17:22:52 +0800 [thread overview]
Message-ID: <20260716092252.251107-1-panchuang@vivo.com> (raw)
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/pmdomain/starfive/jh71xx-pmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pmdomain/starfive/jh71xx-pmu.c b/drivers/pmdomain/starfive/jh71xx-pmu.c
index 74720c09a6e3..aff07b0f5523 100644
--- a/drivers/pmdomain/starfive/jh71xx-pmu.c
+++ b/drivers/pmdomain/starfive/jh71xx-pmu.c
@@ -276,8 +276,6 @@ static int jh7110_pmu_parse_irq(struct platform_device *pdev, struct jh71xx_pmu
ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
0, pdev->name, pmu);
- if (ret)
- dev_err(dev, "failed to request irq\n");
jh71xx_pmu_int_enable(pmu, JH71XX_PMU_INT_ALL_MASK & ~JH71XX_PMU_INT_PCH_FAIL, true);
--
2.34.1
next reply other threads:[~2026-07-16 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 9:22 Pan Chuang [this message]
2026-07-16 12:29 ` [PATCH] pmdomain: starfive: Remove redundant dev_err() Ulf Hansson
2026-07-17 12:09 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716092252.251107-1-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=changhuang.liang@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ulfh@kernel.org \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox