From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E1A848A8C2 for ; Thu, 23 Jul 2026 18:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832366; cv=none; b=tWVZtdhnMWr6AXEfu7MQVGtqOFI9DDio6nC+rH3m02k569fBFYvrk2xi7BZr5e786nkdRIQOwYF1jtqNm/tQMC72hGe/9cF16eO43UwCRnYtgYTohTuQ8BhaJv4E4Mz4seCtvZoCr084E1cemKIwfBR/HwkvZeBerTSCIAaGwY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784832366; c=relaxed/simple; bh=0DUXMETFOiPrjHj0I+f8Jjf1hUhgRxwBlToSkMOuX8E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=k2AC7hz5au0C5NXCbk/uAxmuJbmK6LcTAK+ISbOx8EKWb1+YkunAAT3S75Pbc82oWprEVWcF8HM0tUj0kI80iFzickymk5eKxMyfEKY8VAjVRAjW+yhtznVcH8baYb+IHQD54NkGba3ADLOKf1s/bL6VKJKq4dWJ6GzxQGgNDDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UcuaoKRQ; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UcuaoKRQ" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1065709a91.1 for ; Thu, 23 Jul 2026 11:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784832355; x=1785437155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+cqQ6sQJkvsR3VtIbpEjUXStuHRs0SJj4jk7Uojzitk=; b=UcuaoKRQCbsReVhzJf/ZGJlXbh64b3U6AAC/KmroIrAb+XqaMu03L72UQmO1UfiKoH v5t8SdZGnnvGRm0kSFNoBBew4GakZFP6aUp0kui6MrYim7VuZY25y/41yO+xQdCUuVSt AYyG4u/HZr03V71uuN4Tg/H5roah86A3Hs7n7D/0j87fgcqbgrsjvKIgirqEL8EVhOiX 7gOxTc3j6W0PsrZth3785bq/XUTCNFWLPQqtgqJpSDa8IKj5CH876rkjW/PMTVdQUJ0V ZoxYoGuEX+u+JYgBv4Zw44W3wGn4VBag2holCYN7hZ6yV5iHWiGOKFKN5GFOZqwlTJyB wTzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784832355; x=1785437155; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+cqQ6sQJkvsR3VtIbpEjUXStuHRs0SJj4jk7Uojzitk=; b=mBecS9d9Wxus4SpQf5z92vC9eMLHTXT2l78Nz5FsLF105QSRjJLT6/7XvkiryvWrSM LMm64hkEBLArRNU/MoVEM3oyTprA95655657ewLLKNbRfJKboTtB30/ktKihA2B0zLTD p4iBGW6+oaNKdH/ZSksH0heVguXY3kGsue+W3ahCj6YkNKKChg0Xw6p+R+cTvnu98sNj qiy/VXaN1oXqgfpspBprOG8ylXQtBO5lf/R/2FzZMRTnI9srYiiVGgoooYAMlkRJsQUf c4LIO/xZgX2u48CFTo0P//vB+UH3tmdWKOB2QmfWBxm6E7dQ7Li37hvKCQDoNrDYeWdT sLeg== X-Forwarded-Encrypted: i=1; AHgh+RrSIuT34GArcG/Y+kXZsMLjSc13df8IJ0M2AcgYZ39bEi9UO9sxFDhoWsklCb19ASIaEmGtdjQujQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwYqDL/RUlr4XFhMGawZ7DQuC0qHejuX5lQNNlZN0TWHJgEvXA3 90AkEnrwXCCwKLxsWcTJIHhBb3fAWJpJI5GZWS5v/glrqLuv4/TROPIh X-Gm-Gg: AR+sD11qRLJsvfxS/woC/y4MDDaa0jQcekCl/D2pdtSMMTYAdLNXfbi9vB+VPY09AMC 0sJjJBJUbsM6uVtwR19eCf/3VR5/HY6654muUAi0KnfN5NPndtRPmZE3OybYyAJutzr5n104IWm tskVBmgFUG8H7tJOEDTlK7g9bGzfIIZfa5ygUvIdDXAg1uEACBAMjYRCgU875/aakVYnc7F+hCM FlweVsEgsgVipT+agjtdxlmDk3/8O3eBvl2YY3/WB8RqdYnJhPj1rwBM74yvDUWVxwx8X/ua+0G RSBRZcfwKAPPZjDgLNSwbm9YG/H1nLBJLihOlZefv5Ao1Ge9Clhpr5q77dT72hsjEHGgiIgoN3S TWzcBN9SsxR9Nn/P6SnSQ6fq2Nys6ffTu0ehCQReX1P9195oOEDETFiVupui4qNfytauNYLHu X-Received: by 2002:a17:90b:1350:b0:36d:66d4:270e with SMTP id 98e67ed59e1d1-38ec6455120mr4430242a91.5.1784832354540; Thu, 23 Jul 2026 11:45:54 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03af8a45sm308155a91.10.2026.07.23.11.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:45:53 -0700 (PDT) From: Sang-Heon Jeon To: Julia.Lawall@inria.fr, Alex Deucher , Alexander Shishkin , Alexandre Belloni , Andrew Lunn , Andrew Morton , Arkadiusz Kubalewski , Borislav Petkov , =?UTF-8?q?Christian=20K=C3=B6nig?= , Daniel Lezcano , David Airlie , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Florian Westphal , Greg Kroah-Hartman , Hans de Goede , Hans Verkuil , Heikki Krogerus , Herbert Xu , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Jakub Kicinski , "James E.J. Bottomley" , Jani Nikula , Jaroslav Kysela , Jason Gunthorpe , Jiri Pirko , "Joerg Roedel (AMD)" , Johan Hovold , Jonathan Cameron , Joonas Lahtinen , Julian Anastasov , Leon Romanovsky , Liam Girdwood , Linus Walleij , Maarten Lankhorst , Mark Brown , "Martin K. Petersen" , Matthew Sakai , Mauro Carvalho Chehab , Maxime Ripard , Michael Turquette , Mike Rapoport , Miri Korenblit , Nicolas Palix , Pablo Neira Ayuso , Paolo Abeni , Ping-Ke Shih , "Rafael J. Wysocki" , Rodrigo Vivi , Sebastian Reichel , Shuah Khan , Simona Vetter , Simon Horman , Stephen Boyd , Steve French , Takashi Iwai , Thomas Renninger , Thomas Zimmermann , Tony Luck , Tvrtko Ursulin , Vadim Fedorenko , Vinod Koul , Will Deacon , Yazen Ghannam Cc: cocci@inria.fr, amd-gfx@lists.freedesktop.org, dmaengine@vger.kernel.org, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-rdma@vger.kernel.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nouveau@lists.freedesktop.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 00/36] treewide: remove conditional returns with no effect Date: Fri, 24 Jul 2026 03:45:02 +0900 Message-ID: <20260723184538.3888637-1-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, While reading mm/memblock, I found a conditional return where both branches return the same value: err = do_something(); if (err) return err; return err; Such code is usually a leftover from removing a statement between the two returns, and the tree has about a hundred of these. Patch 1 adds a Coccinelle script that matches the pattern, including negation and constant-comparison variants. Where a local variable is assigned right before the check, the assignment and the two returns turn into a single return of the assigned expression. Patches 2-36 are generated by the script, with hand fixes to restore unexpectedly removed comments and to fix the formatting checkpatch.pl complained about. The patches are grouped by subsystem instead of split per file. If you would rather split, merge or drop your part, just let me know and I will address it in the next version. All patches are independent and can be applied separately, but for everyone's convenience, it would be nice if they were merged through a single tree. The series is based on next-20260721. Sang-Heon Jeon (36): coccinelle: misc: add cond_return_no_effect.cocci drm/amd: remove conditional return with no effect drm/radeon: remove conditional return with no effect dpll: zl3073x: remove conditional return with no effect drm/i915: remove conditional return with no effect drm: remove conditional return with no effect net: ethernet: remove conditional return with no effect net: remove conditional return with no effect net: intel: remove conditional return with no effect wifi: remove conditional return with no effect ipvs: remove conditional return with no effect media: remove conditional return with no effect ALSA: remove conditional return with no effect ASoC: remove conditional return with no effect iio: remove conditional return with no effect Input: remove conditional return with no effect clk: remove conditional return with no effect crypto: drivers - remove conditional return with no effect dmaengine: qcom_hidma: remove conditional return with no effect stm class: remove conditional return with no effect RDMA/ocrdma: remove conditional return with no effect iommu/s390: remove conditional return with no effect dm vdo: remove conditional return with no effect pinctrl: mediatek: remove conditional return with no effect platform/x86: toshiba_haps: remove conditional return with no effect power: supply: pm8916_lbc: remove conditional return with no effect RAS/AMD/ATL: remove conditional return with no effect regulator: wm831x-isink: remove conditional return with no effect rtc: pcf2127: remove conditional return with no effect scsi: mpt3sas: remove conditional return with no effect thermal/drivers/k3_bandgap: remove conditional return with no effect USB: serial: ch341: remove conditional return with no effect usb: typec: fusb302: remove conditional return with no effect smb: client: remove conditional return with no effect cpupower: remove conditional return with no effect memblock: remove conditional return with no effect drivers/clk/clk-cs2000-cp.c | 6 +- drivers/clk/clk-lmk04832.c | 12 +- .../intel/qat/qat_common/adf_gen2_config.c | 8 +- .../marvell/octeontx2/otx2_cpt_mbox_common.c | 7 +- drivers/dma/qcom/hidma_ll.c | 6 +- drivers/dpll/zl3073x/dpll.c | 6 +- drivers/dpll/zl3073x/out.c | 8 +- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 6 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 6 +- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 6 +- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 6 +- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 6 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 6 +- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 6 +- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 32 ++--- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 6 +- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6 +- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 6 +- .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 6 +- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 19 +-- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 7 +- .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 7 +- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 6 +- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 19 +-- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 6 +- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 10 +- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 6 +- .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 19 +-- .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 6 +- .../gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c | 9 +- .../drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 16 +-- drivers/gpu/drm/i915/display/intel_hdmi.c | 7 +- drivers/gpu/drm/i915/gvt/gtt.c | 8 +- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 6 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 14 +- .../drm/panel/panel-osd-osd101t2587-53ts.c | 7 +- drivers/gpu/drm/radeon/ci_dpm.c | 6 +- drivers/gpu/drm/radeon/kv_dpm.c | 30 ++--- drivers/gpu/drm/radeon/si_dpm.c | 14 +- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +- drivers/hwtracing/stm/core.c | 8 +- drivers/iio/light/isl29028.c | 6 +- drivers/iio/light/tsl2583.c | 14 +- drivers/iio/magnetometer/ak8974.c | 6 +- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 7 +- drivers/input/keyboard/pmic8xxx-keypad.c | 8 +- drivers/input/mouse/synaptics_i2c.c | 6 +- drivers/input/rmi4/rmi_smbus.c | 7 +- drivers/iommu/s390-iommu.c | 8 +- drivers/md/dm-vdo/encodings.c | 8 +- drivers/media/i2c/mt9p031.c | 6 +- .../microchip/microchip-sama7g5-isc.c | 7 +- .../media/platform/qcom/iris/iris_resources.c | 6 +- .../media/platform/qcom/venus/pm_helpers.c | 7 +- drivers/media/platform/renesas/rcar-csi2.c | 6 +- .../platform/samsung/s3c-camif/camif-core.c | 7 +- drivers/media/usb/dvb-usb-v2/mxl111sf.c | 12 +- drivers/media/usb/gspca/jl2005bcd.c | 7 +- drivers/net/ethernet/amazon/ena/ena_netdev.c | 6 +- .../ethernet/aquantia/atlantic/aq_macsec.c | 6 +- .../ethernet/freescale/dpaa2/dpaa2-switch.c | 6 +- drivers/net/ethernet/freescale/gianfar.c | 6 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 8 +- drivers/net/ethernet/intel/igb/e1000_i210.c | 6 +- drivers/net/ethernet/intel/igc/igc_phy.c | 6 +- .../ethernet/qlogic/netxen/netxen_nic_hw.c | 7 +- .../ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 6 +- drivers/net/ethernet/renesas/rtsn.c | 7 +- drivers/net/phy/microchip_t1.c | 6 +- drivers/net/pse-pd/tps23881.c | 6 +- drivers/net/wireless/ath/ath6kl/init.c | 6 +- drivers/net/wireless/intel/iwlwifi/mvm/link.c | 6 +- .../wireless/realtek/rtlwifi/rtl8821ae/hw.c | 7 +- drivers/net/wireless/realtek/rtw89/mac.c | 6 +- drivers/net/wireless/realtek/rtw89/mac_be.c | 6 +- .../pinctrl/mediatek/pinctrl-mtk-common-v2.c | 6 +- drivers/platform/x86/toshiba_haps.c | 6 +- drivers/power/supply/pm8916_lbc.c | 8 +- drivers/ras/amd/atl/map.c | 6 +- drivers/regulator/wm831x-isink.c | 6 +- drivers/rtc/rtc-pcf2127.c | 7 +- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 +- drivers/thermal/k3_bandgap.c | 7 +- drivers/usb/serial/ch341.c | 8 +- drivers/usb/typec/tcpm/fusb302.c | 14 +- fs/smb/client/smb1maperror.c | 6 +- mm/memblock.c | 7 +- net/netfilter/ipvs/ip_vs_sync.c | 7 +- .../misc/cond_return_no_effect.cocci | 121 ++++++++++++++++++ sound/pci/echoaudio/echoaudio_dsp.c | 6 +- sound/pci/echoaudio/layla24_dsp.c | 6 +- sound/pci/riptide/riptide.c | 5 +- sound/soc/amd/acp/acp-mach-common.c | 11 +- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 7 +- sound/soc/samsung/smdk_spdif.c | 8 +- sound/soc/sof/intel/hda-dsp.c | 6 +- sound/usb/mixer_scarlett.c | 26 ++-- tools/power/cpupower/utils/powercap-info.c | 2 - 102 files changed, 295 insertions(+), 643 deletions(-) create mode 100644 scripts/coccinelle/misc/cond_return_no_effect.cocci -- 2.43.0