From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CBE73F1AB4 for ; Fri, 24 Jul 2026 08:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882692; cv=none; b=c2Ahq1miWOZU81XaOXW+PPAV3+mXXR28Og5iZy3y+Hx76a6bIfPRKXLjeyVwb5djuIOoiLjF8JY2yPrCbpT8hkZZPL6h+38+unxJHO8MZ+JARuPTRlfj1LzPUAs5ReugSTR5BcBUPNvZ+aB1HBnoD0OXYUrWeS7uhYiAKyGVo7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882692; c=relaxed/simple; bh=DyEec2Z7+FSSh+lvskH9h+/zSvQpOnJC1n/aL86DbdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SA57aJHkwQpefzc8Ae2twsu7oeNbSOVqKRe2OVxqA0sTEDClUH0OMTqBtp1KNZrQKfSj+pNZLO5JFhwwVhDwQK75ul4V9nIP9G58RbYEPsc8KgCjR+QHyJi+W1JZ2LL69Br0p3NtIHneBGB0xKiVk0x1GNTh76rMZaGn9S8YYKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ncvlba2Y; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ncvlba2Y" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38dcbade417so169861a91.1 for ; Fri, 24 Jul 2026 01:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784882690; x=1785487490; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f0rgL0VJ5kE0g1GPB7mxKos5pVHLgytmLF2hovXGdFw=; b=Ncvlba2YNu3OM1Xj6EntAJVtCNguGJud41Y1ZLDetGb0xnij4xGqWytxDzmF5/rv93 xfM42s+nITAVn0EHuFPgGj2FR3VEUqYFEgQDSJsNampMxHOCGH+yifOzBNIgAgxj5wWE U7bo7o1FdFjTOaBBOKbKpAgutiIKVw2LoPI54= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784882690; x=1785487490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=f0rgL0VJ5kE0g1GPB7mxKos5pVHLgytmLF2hovXGdFw=; b=byhVtIPaBSXU8Bh6+dWehulBHJW5C0w7JH2HUWgeaGKpinf2iX0wRnB8aW9BI29AGi YYLlKWDyL3B5/f8iWMcEjb+OqPx21gA2JbklttgsT0ca26qMB81aSBNvq1pzmbk9eQdZ 5h80lSgNWLxUPvVEijneYsaF1TeqtQw6Gb93yocbWso259diGndpS6wznJyvKx3vK/jq OTL1tWSUYZG91b/TyVaZQi/RpZT2/VcZDVASb+UKQYUEPuogOcUxBl8FNsx+NfxzXvOb kiJkfX9ALLUaZo8qL6FoFZuRqBHuNLouDtEMBFBsP+IP9z2u+6YZdK2wcQJBwB7f2K8c yBiw== X-Forwarded-Encrypted: i=1; AHgh+Rr1xvBhZvfaKRo2afku/+fbAh2e88fuIMKqxBVo+xZowHVYXlPFhX5+9Fn6gw3vuSK6sGCMhcO6Vw==@vger.kernel.org X-Gm-Message-State: AOJu0YzS2KOuSCLr5qTNIiVjwiE+pT0+22NUr6I3cK8CpSekkVokm4ME CYS+EkTbnEPgXX3iRm39dz4omtw0WXYR9pRDPs89SSUaISshUyqVhwCp/Bg8CBv+qw== X-Gm-Gg: AR+sD10tn0lGZN4PtEv39xRP7QxcxirZq9A52QoFTYRmz749gIA7zbI8wNdZuZIeq9d NiMhljs1ju11L/TS0Bmo8hm7XwxGEJd1UR/GLTJu5WNHcsJGNo6DNK6C98eKD0cWVEguOWsWuMb NUp0LbS80iwt5V5xw+hmVB6nXFS1GNYOTgeSVZSj7+KUK3ugIeBvYCX9AXGjDnmdkWqM0xZaZjn j9hVaaZ81IOUeKosSMR8FaEpg/TphV+L5RSQGI1pjI/JZ4oCayxrtTmU71dPe+isuEx1nc2MRrH mqYs4LSMzazR6Quak+IcL1eyYGnCEsZQv5j96KrrRjgVHKMbe53wHHJSEd0kv25QfTEl/At4tmr vxtEtLRlKgtqJnu3SDb/a4otjrupO+6dp8w6f/Vo5hry4czJY6rZOZh7aW3NjpogETkKSrDxYr1 bNxsq/CiWNG1jyyf+f48VKnCLAmImYN0jBSqtomI8l425ZdK70sRHiYCFeGO0= X-Received: by 2002:a17:90b:2750:b0:381:5ab5:b667 with SMTP id 98e67ed59e1d1-38ec6637d1amr6239942a91.31.1784882690591; Fri, 24 Jul 2026 01:44:50 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f131:86cc:5858:7325]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f089ac6d8sm434546a91.2.2026.07.24.01.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 01:44:49 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v7 09/16] usb: hub: Use usb_hub_set_port_power() to control port power everywhere Date: Fri, 24 Jul 2026 16:43:18 +0800 Message-ID: <20260724084328.3943997-10-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260724084328.3943997-1-wenst@chromium.org> References: <20260724084328.3943997-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are still some instances in the USB hub driver where port power is directly controlled by toggling the USB_PORT_FEAT_POWER feature flag. Switch these instances over to usb_hub_set_port_power() so that only one unified function to do this exists. This makes adding external power control with the power sequencing API easier and consistently applied. Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - New patch --- drivers/usb/core/hub.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 6671b5e45191..a5c5038e1604 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -976,11 +976,8 @@ static void hub_power_on(struct usb_hub *hub, bool do_delay) dev_dbg(hub->intfdev, "trying to enable port power on " "non-switchable hub\n"); for (port1 = 1; port1 <= hub->hdev->maxchild; port1++) - if (test_bit(port1, hub->power_bits)) - set_port_feature(hub->hdev, port1, USB_PORT_FEAT_POWER); - else - usb_clear_port_feature(hub->hdev, port1, - USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hub->hdev, hub, port1, + test_bit(port1, hub->power_bits)); if (do_delay) msleep(hub_power_on_good_delay(hub)); } @@ -5437,7 +5434,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (hub_is_port_power_switchable(hub) && !usb_port_is_power_on(port_dev, portstatus) && !port_dev->port_owner) - set_port_feature(hdev, port1, USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hdev, hub, port1, true); if (portstatus & USB_PORT_STAT_ENABLE) goto done; -- 2.55.0.229.g6434b31f56-goog