Re: [PATCH v24 08/12] mfd: psci-mfd: Add psci-reboot-mode child cell

[Lee Jones <lee@kernel.org>]

On Wed, 12 Aug 2026, Bartosz Golaszewski wrote:

> On Wed, 12 Aug 2026 10:18:56 +0200, Lee Jones <lee@kernel.org> said:
> > On Mon, 03 Aug 2026, Shivendra Pratap wrote:
> >
> >> The PSCI "reboot-mode" node does not define a compatible because it is a
> >> configuration of boot-states provided by the underlying firmware. With
> >> the new firmware-node based cells in mfd-core, this node can now be
> >> exposed as a proper child cell.
> >>
> >> Add the psci-reboot-mode child cell to the psci-mfd driver with a
> >> named_fwnode. Add psci-cpuidle-domain cell first to isolate it from
> >> reboot-mode failures.
> >>
> >> Suggested-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> >> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> >> ---
> 
> ...
> 
> >> +	if (ret) {
> >> +		if (ret == -ENOMEM)
> >> +			goto out;
> >> +		dev_warn(&pdev->dev, "reboot-mode child cell failed to add: %d\n", ret);
> >
> > Okay Yoda, but why is this okay?
> >
> 
> Hi Lee,
> 
> I'd like to call you out on this because making snarky comments on a non-native
> English speaker's syntax is really not OK. Please don't do this. As a native
> speaker you could have just proposed a better sounding version.

It wasn't supposed to be offensive, it just made me chuckle.

I unreservedly apologise if any offence or ill-feeling that may have occurred.

-- 
Lee Jones