From: Krzysztof Kozlowski <krzk@kernel.org>
To: Robin Snyders <robin@snyders.xyz>
Cc: Casey Connolly <casey.connolly@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: qcom,pmi8998-charger: add SMB5 PMICs
Date: Thu, 13 Aug 2026 10:51:05 +0200 [thread overview]
Message-ID: <20260813-festive-holistic-shellfish-1ee0de@quoll> (raw)
In-Reply-To: <20260812-submit-qcom-smbx-send-v1-v2-1-f504b8f9bfad@snyders.xyz>
On Wed, Aug 12, 2026 at 01:56:59AM +0200, Robin Snyders wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> Add compatible strings for PM7250B and PM8150B, which contain the SMB5
> generation of the Qualcomm switch-mode battery charger. PM7250B uses the
> same charger interface and parameters as PM8150B, so require the PM8150B
> compatible as its fallback.
>
> Clarify the IIO channel descriptions because SMB5 exposes a USB current-
> sense voltage while SMB2 exposes an already-converted current.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: Robin Snyders <robin@snyders.xyz>
I don't get one thing - you used b4 to send it, so how could this be
threaded to some other email thread? Do not introduce custom workflows,
please. b4 is there to make it right, so just use it in standard way -
b4 trailers, b4 prep -c, b4 prep --edit-cover, b4 prep --check, b4 send.
> ---
> .../bindings/power/supply/qcom,pmi8998-charger.yaml | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-13 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 20:35 [PATCH 0/3] power: supply: qcom_smbx: add SMB5 support Robin Snyders via B4 Relay
2026-08-11 20:35 ` [PATCH 1/3] dt-bindings: power: supply: qcom,pmi8998-charger: add SMB5 PMICs Robin Snyders via B4 Relay
2026-08-11 20:35 ` [PATCH 2/3] power: supply: qcom_smbx: add SMB5 support Robin Snyders via B4 Relay
2026-08-11 20:35 ` [PATCH 3/3] power: supply: qcom_smbx: program AICL rerun time Robin Snyders via B4 Relay
2026-08-11 23:56 ` [PATCH v2 0/2] power: supply: qcom_smbx: add SMB5 support Robin Snyders via B4 Relay
2026-08-11 23:56 ` [PATCH v2 1/2] dt-bindings: power: supply: qcom,pmi8998-charger: add SMB5 PMICs Robin Snyders via B4 Relay
2026-08-13 8:51 ` Krzysztof Kozlowski [this message]
2026-08-11 23:57 ` [PATCH v2 2/2] power: supply: qcom_smbx: add SMB5 support Robin Snyders via B4 Relay
2026-08-13 8:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813-festive-holistic-shellfish-1ee0de@quoll \
--to=krzk@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robin@snyders.xyz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox