From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>
Cc: Guillaume La Roque <glaroque@baylibre.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings
Date: Thu, 13 Aug 2026 10:28:16 +0200 [thread overview]
Message-ID: <20260813-international-optimal-limpet-dfb06e@quoll> (raw)
In-Reply-To: <20260811-a9-thermal-v2-1-7ddc33b11b9a@amlogic.com>
On Tue, Aug 11, 2026 at 08:37:43AM +0000, Xianwei Zhao wrote:
> Document the thermal controller compatibles for the Amlogic A9 SoC.
>
> Describe the required "core" and "plck" clocks, add the optional
> "amlogic,hw-reset-temp" property, and update the schema constraints for
> A9-specific thermal controllers.
>
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> .../bindings/thermal/amlogic,thermal.yaml | 28 +++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> index 8cfa44dcda58..f73ee66bcc47 100644
> --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> @@ -23,6 +23,7 @@ properties:
> - const: amlogic,g12a-thermal
> - enum:
> - amlogic,a1-cpu-thermal
> + - amlogic,a9-thermal
> - amlogic,t7-thermal
>
> reg:
> @@ -32,7 +33,13 @@ properties:
> maxItems: 1
>
> clocks:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: core
> + - const: pclk
>
> power-domains:
> maxItems: 1
> @@ -52,6 +59,10 @@ properties:
> - description: phandle to the secure monitor
> - description: sensor index to get specific calibration data
>
> + amlogic,hw-reset-temp:
> + description: The hardware-controlled reset temperature value.
> + $ref: /schemas/types.yaml#/definitions/uint32
Thermal zones define that, not custom properties.
> +
> required:
> - compatible
> - reg
> @@ -73,6 +84,21 @@ allOf:
> required:
> - amlogic,secure-monitor
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,a9-thermal
Why is one clock valid as well for the new device?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-13 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 8:37 [PATCH v2 0/2] thermal: Add support A9 Xianwei Zhao via B4 Relay
2026-08-11 8:37 ` [PATCH v2 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings Xianwei Zhao via B4 Relay
2026-08-13 8:28 ` Krzysztof Kozlowski [this message]
2026-08-20 6:38 ` Xianwei Zhao
2026-08-20 6:49 ` Krzysztof Kozlowski
2026-08-20 7:16 ` Xianwei Zhao
2026-08-11 8:37 ` [PATCH v2 2/2] thermal: amlogic: Add support for A9 thermal controller Xianwei Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813-international-optimal-limpet-dfb06e@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox