From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1CFD4AE113; Thu, 3 Sep 2026 13:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788443947; cv=fail; b=RQIQo7+QXDXLkS8JeFVLOggn7qfYmnCwX8uye2fWV+BiDYU6D9MYhlqzn4058MNGZGXKvWJpNUZ86928o3slJ/qYAgnnsRx9NyR12FIhcjbtlnJI2gFWZLiY2jwHOwEC4edcDSQGbPkGZquCzFfITb2/H/YPyM8c6da+e2pDQVQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788443947; c=relaxed/simple; bh=r03ZsYU89+XEPHLWblUwudSP6MUz92Gfb0U/AMrantY=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LuVLIrI/LZcMb+NZhUfYKwU0IoaWra7pso/tCVgO5xhAJ5aIvT9iIDlYvI9Z04lNbqcWDvWpL3t8bgyMRCwJd8RS3GaGjjq9wgVi3Hv0qM/gO2XjxT1e/HdTwI52bR9rg9+nOEnKhsiBYgB9wyFgq4nTsrtas/8QZh3qqUaWSEs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=CilV3rtJ; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=q8fOCawR; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="CilV3rtJ"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="q8fOCawR" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 683D8a3D3762163; Thu, 3 Sep 2026 08:58:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=proofpoint-05-2026; bh=P3QJhr1WVaWaHjj ln+nBmoHirUY99anhuPCAo/MT3ws=; b=CilV3rtJmHkkr5Th7vp+MgSqcxeCJnv XpU6MjZtCvEljOvHQBvYuRcJDqh+0DF+fHlOo0PZs3FSpdPKpLKZ5kf4mdU3EaEs chrZK+YZOjT69oNmwE6LZEl2Oq7B1wkyNRQCi3sPkpQOAj2aHkauBKczy/fdKA4t TGfVA2p8QSQcFHG4rUfKpQTpzWMel43JSZHuI2k1tNYi3KafRFYHyGQxs0DfVgnL NGpH8EA4LOIdF/1V80G995KSW4Bh+jWeiwy7zQwtqrMQU3eDvcVItLBoggdJ3mKA wrRElEpPbIYAYzhqVxXV9/v+DoCDrTErxNWl/DTSsP9Xb/wdrVYhEYQ== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11011050.outbound.protection.outlook.com [40.107.208.50]) by m0384305.ppops.net (PPS) with ESMTPS id 4gf0jv3drh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 03 Sep 2026 08:58:48 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cCjyqmThpzpW7a9IqehL9GohVLtNKm2wnwFw9uWRtzC5W3uhtIPW33b7f3bdrbl2QeH4NweyU4InV+iF0N7WRk2iFh4pA/NZ2FsEEmNEgQPyUvquKOSM3uGeLbX3rLb829TWGMv4LRBpWETr8ER9DSvq5KvHAbeZWo7tT0g00PvnRw9HIIYfYUoJmzLhKEAOyF7MF2fsJxdykQgxAwtzvnv96JO+c6MyzJaseNVIX+8iDiVnybb76wf/kSAdKxzkup72ZkIDbv73W8gKJFcLiYZZ0pMRXbyeSqpGsWgOY+IzjvPYQOlAkqlO2293UsQyJcrN5tkzdkPPwMEQDrtaCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P3QJhr1WVaWaHjjln+nBmoHirUY99anhuPCAo/MT3ws=; b=jpwipAHJvKVvWA1ypC3d+DWNh3002M9yeDKnoNv6qnsUbP5gplmaDh+v7uNR2l7qtf/gKLa++i0UqeHreaj4dleVDUU/4oXqY3vfUd9zTmci9dbvp8jMZazdHQVzv1blLtzkWkyJ1ll4bRNfTVOGvT8C8neyiG9Gnq9TFbHarWRGn2fWx6H2y6XdXCfIwY0MGzmmSq0P44Fx6UG1voKMM2w7VMz/T2gUNrtfKLpBh00zNet8HHLwEY2lerlhNNbsf/Li1WjAywwKX4WzOqgu3d/0bom1U7636aage0iScbmQBPbPRG+zSNL6xo5x6s3gNdGS+PcHvTeh2+o9zNsfXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P3QJhr1WVaWaHjjln+nBmoHirUY99anhuPCAo/MT3ws=; b=q8fOCawRnW+VWp+s6HKtj5cW1PQhJBdAJJCh7yPyQF2pmLTD/TB4vEpciLlOYzHWVxt4mHhtnSdSBSkoSCeCXhd/vC4whCkinf5GqWBwg+nc1ypNUZwgRCr6U+rL6gYuWfvdEy1puTqoW3kInvKg0YbrLJ7sgrVrd/QiDUOkbDM= Received: from BLAPR03CA0179.namprd03.prod.outlook.com (2603:10b6:208:32f::33) by PH3PPFAE1A1621A.namprd10.prod.outlook.com (2603:10b6:518:1::7bd) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Thu, 3 Sep 2026 13:58:38 +0000 Received: from BN1PEPF00006003.namprd05.prod.outlook.com (2603:10b6:208:32f:cafe::76) by BLAPR03CA0179.outlook.office365.com (2603:10b6:208:32f::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.13 via Frontend Transport; Thu, 3 Sep 2026 13:58:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN1PEPF00006003.mail.protection.outlook.com (10.167.243.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Thu, 3 Sep 2026 13:58:37 +0000 Received: from DLEE203.ent.ti.com (157.170.170.78) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 3 Sep 2026 08:58:14 -0500 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE203.ent.ti.com (157.170.170.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 3 Sep 2026 08:58:14 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 3 Sep 2026 08:58:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232] (may be forged)) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 683DwEr71647012; Thu, 3 Sep 2026 08:58:14 -0500 Date: Thu, 3 Sep 2026 08:58:14 -0500 From: Nishanth Menon To: Randy Dunlap CC: , Sebastian Reichel , Subject: Re: [PATCH v2] PM: SmartReflex: fix kernel-doc warnings in smartreflex.h Message-ID: <20260903135814.3m3mdu2voaacfk7c@hatless> References: <20260831055059.3456532-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260831055059.3456532-1-rdunlap@infradead.org> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00006003:EE_|PH3PPFAE1A1621A:EE_ X-MS-Office365-Filtering-Correlation-Id: ca312034-82c3-4b49-be26-08df09c37405 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|82310400026|1800799024|23010399003|10067099003|56012099006|13003099007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: HPUaILULNJRzg5SQQFrzGDQ84obtAPXC2gDCovDa+L03rntVxqtAj4RZXNoSveGDAQE9OijqyLvbl3dliadFri1bCBLySr79bRDnIaQMCYp8qme5/rdFIDA8DSxzeie0JyaBCa8gb9VMQ4mjCrkHIpe+UOWNk/7Fi6NAtWpvLmjpNc4lRbLxzKyInsBMlpEDOav3O/7eRgMdNgSvfY9nd3AKQrm2NLc9YF+Ju9z9nnOFaTSPnLBCSoSrHW2nKqz85z0W2Hz+R+8cjdzK+BFMPsdtf1s4wL9U4/pQBTFqZEQU7FeLkqb/RE7f90fvN2LjtdgtxCNXze9wi1sHCqHpmlaEmaihViat07wpKbG6uiM5krk4rm1fwWl28QZzvDlRZJfYmAgq51g2hVJK2duT3bzyPiTKj0JYyE5GoKaHRITT5xXLskw9beRGvhwyUc8zzNJfM2wqyn4SXmNYOtgqlxLj3oIvRPxen3jdbJVI7PmALzP7XgN4P7XaajJrRainfbaclgNNQjA86TIfUUJh8T1SWzcQM2z4bK0TP7bycQOA/XeLSV6Xe1AngiuNQoFRHQ7nsJEL3f89O6knBKbad687uHCiIimCEnM+2HXnN2ondk9G6hp4y+VE56+F04uELeme/FuJrlwUvw00353jSA== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(82310400026)(1800799024)(23010399003)(10067099003)(56012099006)(13003099007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: N8a9/KmCuAAL7am/YxtBaGwxgNFqJsjYNTLiSG/94/4IWOFrA6seSYswpbjRHIyzzLUUZ2YaUOEERJ2cwZyUD+JqpN7HUeH1MAo7e6C750a/pjg2imKvkGSkD2duzpoFyy1J0FtfenPhpZy2eu982+Rt8YbwnboGtS5bI5DFZo7TJ4sg3zqR+lpHBAmmdEoQ1kwwlWtRsKS3U+QvJMfqM2t7s4x9/nLecxnKmAaKHMbL83IufaB8xdcnhI07Cq2oDjLlbVKDjRPkUYEy4FXE/xjCBhXPPZPQ89Jyfgo7XC+81eoV7ul1k/4I5jMUkJjn695YKMD3s5KZxwzwSAqfjj/BN63JviZOf4sjY35z1gBNc3Rmx36YTtCiphuczDUyWjgZSmDVMLSFVSovjTOKogncqGg7soDUMj9sJKjKZnOPV8/J4aZ28wul3hMCOjok X-Exchange-RoutingPolicyChecked: qLpsmYs1DwgjAhpaGjQzulML0+B34Sw6BUO/mImdnITlvM1yW3KZyenVdRsocHvDNR4mh4UQ0D+iOo9o08Xy7n6JecQZ+YY/ADRsGuPcuKiLUIc+PaqR0e+d6TwnZkplluL5EQBd4zkPSkV09dV+PWjEx+ARG6z9GaoueJw9XBqpJTW3Kxu+pvubwUZ6A7BC0SNI+p+U7+5AR9rZoKhxvimaBMTxMXJF1flpje8CGIRto0rLqovnEKnMeVOuO9koTyzNssrupBvuPgAhcydaG6I+bL7aYazwYFN+kyKQ3SYM6vhUdcZXamEXxM8ijGaOi6aepGHCrD/R9Lwe0CtEjA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2026 13:58:37.8587 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca312034-82c3-4b49-be26-08df09c37405 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00006003.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPFAE1A1621A X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDEyMSBTYWx0ZWRfX9jOyQr5gnQrb ikYGrm7NiqIyoONUZvR2gXEzcbDiAQUEmMZNhZzOmEaWbQM9fRYOkNx3B3OrkOxlkDb3AiQPorT aIcq90P7GFw9x9xHdSfO+UTL76hiAU4= X-Authority-Analysis: v=2.4 cv=J6eaKgnS c=1 sm=1 tr=0 ts=6a997d19 cx=c_pps a=v7DXidBSvHT+GL4JoI7fUQ==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=JfrnYn6hAAAA:8 a=VwQbUJbxAAAA:8 a=HlEdLX5HuMd4NyMpm4YA:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-GUID: jRiRL7nmKmH95xhkFbpUft-D81UCrt1p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDEyMSBTYWx0ZWRfXzywblMswuw6B XT9LRruqp4ERGTOPhLIadk0ipsycf96uKeuWCwoF9qRbHzQdFm3vGWj64S/gQ1D6R2d7a+uMIOO I6cmUXEByjIhx0uOGt3T2SNlLicyJvVd3W/1WXIJ9d6XHqdlvpJCnhF6BR/GbciK8ciidIggFPA sr8L3p51UUGojg0ZPvHyIMwmXvzZKdy0M0/V+/JbUzjryjH8Ijvn4ctQcy6gdqO2Ih388BsbcUI J2CMGUQPPkk85ipZyqVB/VxY1yVC7qDzW789ZbnoJr6I0Zlaqrt6feahlUahccUQ8AA2JcAKNDm Xu0LK55Dh986zPEnFLgUfCmSnZOz221hUzZYjJFkbg7E0LVsb7wX/NglUd4Bh011uxIQ5gkJ4w0 uR/vzDlYCFCsRGqz3WxYqdKLndfrKwnAe2OtMWpKANL2Jb5o6K7gOifcvfI1MfrsIthfjfM+KJm kbNfELhfd4vvLUG3b/A== X-Proofpoint-ORIG-GUID: jRiRL7nmKmH95xhkFbpUft-D81UCrt1p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_04,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1011 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030121 On 22:50-20260830, Randy Dunlap wrote: > Use the correct function name in a kernel-doc comment and > use the correct kernel-doc format for struct members to avoid > kernel-doc warnings: > > Warning: include/linux/power/smartreflex.h:187 expecting prototype for > test_cond_timeout(). Prototype was for sr_test_cond_timeout() instead > Warning: include/linux/power/smartreflex.h:292 struct member 'err_weight' > not described in 'omap_sr_data' > Warning: include/linux/power/smartreflex.h:292 struct member > 'err_maxlimit' not described in 'omap_sr_data' > Warning: include/linux/power/smartreflex.h:292 struct member 'accum_data' > not described in 'omap_sr_data' > Warning: include/linux/power/smartreflex.h:292 struct member > 'senn_avgweight' not described in 'omap_sr_data' > Warning: include/linux/power/smartreflex.h:292 struct member > 'senp_avgweight' not described in 'omap_sr_data' > > Signed-off-by: Randy Dunlap > --- > v2: rebase & resend > > Cc: Nishanth Menon > Cc: Sebastian Reichel > Cc: linux-pm@vger.kernel.org > > include/linux/power/smartreflex.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > --- linux-next-20260828.orig/include/linux/power/smartreflex.h > +++ linux-next-20260828/include/linux/power/smartreflex.h > @@ -174,7 +174,7 @@ struct omap_sr { > }; > > /** > - * test_cond_timeout - busy-loop, testing a condition > + * sr_test_cond_timeout - busy-loop, testing a condition > * @cond: condition to test until it evaluates to true > * @timeout: maximum number of microseconds in the timeout > * @index: loop index (integer) > @@ -267,11 +267,11 @@ struct omap_sr_nvalue_table { > * @ip_type: Smartreflex IP type. > * @senp_mod: SENPENABLE value of the sr CONFIG register > * @senn_mod: SENNENABLE value for sr CONFIG register > - * @err_weight ERRWEIGHT value of the sr ERRCONFIG register > - * @err_maxlimit ERRMAXLIMIT value of the sr ERRCONFIG register > - * @accum_data ACCUMDATA value of the sr CONFIG register > - * @senn_avgweight SENNAVGWEIGHT value of the sr AVGWEIGHT register > - * @senp_avgweight SENPAVGWEIGHT value of the sr AVGWEIGHT register > + * @err_weight: ERRWEIGHT value of the sr ERRCONFIG register > + * @err_maxlimit: ERRMAXLIMIT value of the sr ERRCONFIG register > + * @accum_data: ACCUMDATA value of the sr CONFIG register > + * @senn_avgweight: SENNAVGWEIGHT value of the sr AVGWEIGHT register > + * @senp_avgweight: SENPAVGWEIGHT value of the sr AVGWEIGHT register > * @nvalue_count: Number of distinct nvalues in the nvalue table > * @nvalue_table: table containing the efuse offsets and nvalues > * corresponding to them. Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D https://ti.com/opensource