From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chen-Yu Tsai <wenst@chromium.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Wei Deng <wei.deng@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-acpi@vger.kernel.org, driver-core@lists.linux.dev,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v8 07/16] usb: core: Move struct usb_port and related APIs to port.h
Date: Fri, 4 Sep 2026 19:52:37 +0200 [thread overview]
Message-ID: <2026090433-chair-tidings-5c99@gregkh> (raw)
In-Reply-To: <CAGb2v65MSxL+r+wqMjPKVSh9aS1gkn8og6oBinSXDdipnoOyCQ@mail.gmail.com>
On Sat, Sep 05, 2026 at 01:24:20AM +0800, Chen-Yu Tsai wrote:
> On Sat, Sep 5, 2026 at 12:47 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Sep 04, 2026 at 04:41:46PM +0800, Chen-Yu Tsai wrote:
> > > |struct usb_port| and its matching container_of() macro should live in
> > > its own port.h, matching the split we have for .c files.
> >
> > Why?
>
> This was requested by Andy. And to me it sort of made sense.
>
> > > Move them as described. Also move usb_port_is_power_on(), since in the
> > > next change its |struct usb_hub *| parameter will be changed to
> > > |struct usb_port *|, and becomes a non-static function that only
> > > references |struct usb_port|.
> >
> > No, please don't do that unless you have a really good reason.
>
> Which part? Move the code?
Please don't make a new .h file.
Moving the function might make sense on its own if you need it in a
different file later on, but do a move only, and then change things if
you really need to do that.
thanks,
greg k-h
next prev parent reply other threads:[~2026-09-04 17:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 8:41 [PATCH v8 00/16] arm64: mediatek: Add M.2 E-key slot on Chromebooks Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 01/16] device property: Add fwnode_graph_get_port_by_id() Chen-Yu Tsai
2026-09-04 20:18 ` Sakari Ailus
2026-09-04 8:41 ` [PATCH v8 02/16] device property: Add fwnode_graph_get_next_port_endpoint() Chen-Yu Tsai
2026-09-04 20:22 ` Sakari Ailus
2026-09-04 8:41 ` [PATCH v8 03/16] power: sequencing: Add pwrseq_get_state() Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 04/16] usb: hub: Use assign_bit() in usb_hub_set_port_power() Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 05/16] usb: hub: Return actual error from hub_configure() in hub_probe() Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 06/16] usb: hub: Associate port@ fwnode with USB port device Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 07/16] usb: core: Move struct usb_port and related APIs to port.h Chen-Yu Tsai
2026-09-04 16:40 ` Alan Stern
2026-09-04 16:44 ` Greg Kroah-Hartman
2026-09-04 17:24 ` Chen-Yu Tsai
2026-09-04 17:52 ` Greg Kroah-Hartman [this message]
2026-09-04 8:41 ` [PATCH v8 08/16] usb: hub: Pass |struct usb_port*| to usb_port_is_power_on() Chen-Yu Tsai
2026-09-04 16:44 ` Alan Stern
2026-09-04 8:41 ` [PATCH v8 09/16] usb: hub: Use usb_hub_set_port_power() to control port power everywhere Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 10/16] usb: hub: Power on connected M.2 E-key connectors with power sequencing API Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 11/16] dt-bindings: usb: mediatek,mtk-xhci: Switch to ports for USB connections Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 12/16] power: sequencing: pcie-m2: support matching on remote "port" node Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 13/16] power: sequencing: pcie-m2: Add usb and sdio targets for E-key connector Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 14/16] power: sequencing: pcie-m2: Split Bluetooth unit based on interface Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 15/16] arm64: dts: mediatek: mt8195-cherry: Add M.2 E-key slot Chen-Yu Tsai
2026-09-04 8:41 ` [PATCH v8 16/16] arm64: dts: mediatek: mt8188-geralt: Add WiFi/BT as " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090433-chair-tidings-5c99@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=heikki.krogerus@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=wei.deng@oss.qualcomm.com \
--cc=wens@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).