Linux Power Management development
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Ryan Brue <ryanbrue.dev@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Henrik Grimler <henrik.grimler@axis.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: power: supply: battery: allow 101 ocv-capacity points
Date: Thu, 24 Sep 2026 18:24:48 +0100	[thread overview]
Message-ID: <20260924-reaffirm-mop-49234cf37e9a@spud> (raw)
In-Reply-To: <20260923-rbrue-suez-upstreaming-battery-ocv-table-128-v2-1-b827406d768d@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]

On Wed, Sep 23, 2026 at 10:15:35PM -0500, Ryan Brue wrote:
> ocv-capacity-table-N is capped at 100 points, while the capacity percent
> in each point may be anything from 0 to 100. A table with a point for
> every percent, both ends included, needs 101 and does not fit. Raise the
> cap to 101.
> 
> power_supply_get_battery_info() sizes each table from the property, so
> no kernel change is needed.
> 
> Assisted-by: LLM

Crazy what people seem to need LLMs to help with.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

> Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
> ---
> As discussed with Henrik on v1: rather than a larger cap for one vendor's
> tables, which fit in 100 points once resampled, allow the one extra point
> that a table at every percent from 0 to 100 needs, and say so in the
> binding.
> ---
> Changes in v2:
> - Raise the cap to 101 instead of 128, with a comment saying why (Henrik)
> - Drop the justification from the vendor's tables; the figures in v1
>   were for a different cell, and resampled tables fit in 100 points
> - Rebase on v7.3-rc4
> - Link to v1: https://patch.msgid.link/20260918-rbrue-suez-upstreaming-battery-ocv-table-128-v1-1-f477ef39ef0d@gmail.com
> ---
>  Documentation/devicetree/bindings/power/supply/battery.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml
> index 8ebf05d9497c..9575ee1491bb 100644
> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml
> @@ -154,7 +154,8 @@ patternProperties:
>        of the battery and corresponding battery capacity percent, which is used
>        to look up battery capacity according to current OCV value. And the open
>        circuit voltage unit is microvolt.
> -    maxItems: 100
> +    # One point for each capacity percent from 0 to 100
> +    maxItems: 101
>      items:
>        items:
>          - description: open circuit voltage (OCV) in microvolts
> 
> ---
> base-commit: 93f51579e7df248780214094418f205253383cc5
> change-id: 20260917-rbrue-suez-upstreaming-battery-ocv-table-128-9ba83f9313bb
> 
> Best regards,
> --  
> Ryan Brue <ryanbrue.dev@gmail.com>
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-09-24 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  3:15 [PATCH v2] dt-bindings: power: supply: battery: allow 101 ocv-capacity points Ryan Brue
2026-09-24 17:24 ` Conor Dooley [this message]
2026-10-04 17:46 ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924-reaffirm-mop-49234cf37e9a@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=henrik.grimler@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ryanbrue.dev@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox