From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5814E4E73B2 for ; Tue, 29 Sep 2026 10:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790676368; cv=none; b=BU7/9SJRH1bf7UYEbclixGCxFZW5+I+Cc9QykcmHI7XjVVhK0K2nKCNW1Nbnzuvj/0pAO+JCOw3XLoswpS53Jm4xR4dr0dqfkMn4KuLoxWDyypvm2yjS/kR0nAb91rMMF+4Bnu2a5MeskRYz4E+d2I1tY0Ac4igjDz7vG9iBoAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790676368; c=relaxed/simple; bh=xNlUmKwbQXLSEE3QC0Rx5R5Pncj1II95pqPAg1hd7CY=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=lyn2CI9G6lsKeJNrRvJyiVWEzR0GPpn7hGsJhyUS1bNH5qQHjwiXdvBkgj2SRYXBII9ylnX0dgrC7S8qiQGft2HY+Eu0eZ7KsH710hxKtIBAX/qmOMfug2VaRnJFG9gMMtkYn00TrekCdzGbcA7PGKgm0vexD2qrf01Sl6hVTXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=cymnc4JG; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="cymnc4JG" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-4843796e373so2271621f8f.1 for ; Tue, 29 Sep 2026 03:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1790676357; x=1791281157; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=G3eWez+V61iDGrqgukhgzGO2U/52pms2AtqUAmMdSCY=; b=cymnc4JGNiJaiBKPvPL7OFk+ctzIgiTlpVb/8UuCxR5YWiGodr28g3sX93MtxcLODB I3/o08LPbxdsviLnAjLpFoGQnTzE9KOs4dnnp3YoaGrTlSoPul3kjggB8aEDAkjPakLh 2OqjZKAqYWiwNVCXrCBm7xcecjjXhlI4oN6I8jeHvnDiK59/jZJFZKNHKcnq3QwvpzBH A6+Rr29zp1CnkcXPnA/DcdEjnTPGwL9wCU4EA9c/aa+0wafjKd80KMuraBBgSUVkSF4G e1UDnH6efpgy1ney6YiI2kJDfozsfB6M0SZ/fj9NMlKL12QJihWGqVCErll4cqlUMkxl 08Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790676357; x=1791281157; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=G3eWez+V61iDGrqgukhgzGO2U/52pms2AtqUAmMdSCY=; b=zKk7cwbGDEPbC1Pors049fmKCxO1q426ews94eIAP4lIrbUuSCHwgShQa5aeYmspXm EOT0kIZE4PQVU6jJ+tHtfK465wbOr9ZDYR4MIs0ZQINT1+8frd/7XWPJruvJEi+CWXHl GjlbqT1ysFrnyt82U56DCLbsI4mWU8kq8XD0geMmVya4cCicHhZt3tN4KM8fNPhoRSqg jRP4Awx4v4+SdZEma1F29583UPEgNUIfvcUL0Qo4+C9MAmAqWl8vICRxiWtUgZf4yosY rhUmpgfwBEHIaolE2gTPm14R9o3QXGI4V+KAQGTuVlwzBTDc/x5ZDf6NckInma2XkYQo Mr6g== X-Forwarded-Encrypted: i=1; AKwUvBwE4F2TtNLnCSk0dvxbV3HgrcipwaUBJN37mKVh7w6wLARZCGVFosEGctUIAymUjYIjOy0HC1fgvw==@vger.kernel.org X-Gm-Message-State: AFq9FYLhlXEm0FRnC+wwYhjs8zWV22exxhmjLc/Qb4eYS9o2N0anjx51 TxaD3lIi8364w0FZggY2oac3pGv7OLG6uZoSxjSRlrIrA48K7AK4qTIn0drAZdJIi+g= X-Gm-Gg: AYBFou2GMUQUNLAwylc5XoibR5wyWcGEcXrMbxi5jGGfe2346vC/RUMZv2bu8pMpAG2 jw3VGCS8RulJKiB+vpCqFRU8uapevbcs0hoWwKNwJo7y0W6c2cJIWUZU/QFabp+ECRwcq4XXLvv 8u2ZBMLZiI8W9KdY9AZG8GGLIlCQpJKPDf6qh8Uk6E5re7fIBDw0H5KbAgSiN9RN8jx1xCyv89l V/ZUvnbPDDU8qFcEolaMUNWHLKNZ3FAezO+s6TWU60WLI8kf1ABrFMJiKWyk1I1mRtXsJxNrtgD UhlPJhZkpp7xs+ioE449dWQlYUr0Id+qJF0q9nw3DnOR6D4bDb1DpT2ZmsDvpuJDRv8Lxonf2se vlt/VRiGogIbwM32pvSrKYQglXXWqxtdGon+gYiQXtLxWc8Z3abUelMT+CB1oEc4FuSoDwuKVEH J2IjNoHlcSFch9xAD9anJe8Bg2HYAdeyyEtjWlY/e6ewmfpw9iFsiCaLc2AxXFkUx0S+WIY0xhV DGzdnaAblQxWVxx X-Received: by 2002:a5d:5f87:0:b0:488:87f6:c20c with SMTP id ffacd0b85a97d-48887f6c7bamr16422031f8f.13.1790676357052; Tue, 29 Sep 2026 03:05:57 -0700 (PDT) Received: from alchark-surface.localdomain ([5.194.93.183]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48af502f79dsm2954995f8f.6.2026.09.29.03.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 03:05:56 -0700 (PDT) From: Alexey Charkov Subject: [PATCH 0/4] regulator: of: Fixes to of_regulator_bulk_get_all() Date: Tue, 29 Sep 2026 14:05:45 +0400 Message-Id: <20260929-regulator-get-all-v1-0-e887c66a47f1@flipper.net> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMQQqDMBBG4avIrDugES32KqWLmP6JU4KWSRRBv HvTdvkt3jsoQQWJbtVBik2SLHNBc6nITXYOYHkWk6lNXw9mYEVYo82LckBmGyPbrmtxbb1vHKh 0b4WX/fe8P/5O6/iCy98RnecHY4OSJHUAAAA= X-Change-ID: 20260929-regulator-get-all-a553e73ff1ce To: Liam Girdwood , Mark Brown , Corentin Labbe , Manivannan Sadhasivam , Bartosz Golaszewski , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= Cc: linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bartosz Golaszewski , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org, Sashiko X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1317; i=alchark@flipper.net; h=from:subject:message-id; bh=xNlUmKwbQXLSEE3QC0Rx5R5Pncj1II95pqPAg1hd7CY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWTt7m1uqD1g4zN7rbndrd4VWyvdD7x5cufyy9aprxOO/ D60+sqcro6JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BIx1jHiIGLUwCmeukBRobtDh+zuZZul7tkFaujVxdmL5/4WlzxqOnZqDDz0BnGiZcZGe7XMsy d4OEXfnvCgVNeb/+yMV/6YH37fsdXfd0/guYB7ewA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 of_regulator_bulk_get_all() only fills in the .consumer part of the struct regulator_bulk_data for the regulators it gets, leaving .supply as garbage, while the rest of the regulator core expects a meaningful name there (e.g. for error prints), causing uninitialized memory access in any failure paths in the core. It also allocates the supplies array and hands it to callers, but never says the callers need to free it (which they don't), causing leaks. Fix both (the latter in two instances). Signed-off-by: Alexey Charkov --- Alexey Charkov (4): regulator: of: fill in supply names in of_regulator_bulk_get_all() regulator: of: state who owns the array from of_regulator_bulk_get_all() power: sequencing: pcie-m2: Fix leaking array from of_regulator_bulk_get_all() PCI/pwrctrl: generic: Fix leaking array from of_regulator_bulk_get_all() drivers/pci/pwrctrl/generic.c | 1 + drivers/power/sequencing/pwrseq-pcie-m2.c | 2 ++ drivers/regulator/of_regulator.c | 29 ++++++++++++++++++++++------- 3 files changed, 25 insertions(+), 7 deletions(-) --- base-commit: 6375e61c01e93e35ee7acd336a689ac1fae4b509 change-id: 20260929-regulator-get-all-a553e73ff1ce Best regards, -- Alexey Charkov