From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 308E93B5318 for ; Tue, 29 Sep 2026 10:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790676374; cv=none; b=kH11nOeOUvfmiVR26LUNX/gCPapeRp5tc9rTVgSrXLHUzkBZckORoeuOgE45+qyB6izC4bklAYwOHlnm/aVUu5YjnZO3vHSU/n7/P7ud3C5f2FbIKG3OaNNqFZT7NXNxzjl8e/38hcj8C++4ZrXiF9Ofc0TkV9n7RrEtHUuUCQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790676374; c=relaxed/simple; bh=qOkoB1UvmuC4YZqe5Fz1zEEcDa7BiDDxjJDSjZCF8fI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jbXPbGK6/i/Uky4tSh9JXFKx6h8n+ugGvCvoCbskzizsHGdiv+zpIM42mX/EOSSvGnfmHA9656Bi14VYRZz99Pp3E98uFrAOUQfEo8YyFBXbm4jEru3cfNaNGzfPz6bfPCSDqlnGdj+CDS0R7Osp9aUpar5jOKldpcornwYLh+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=B99OoG1s; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="B99OoG1s" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-4843c3ea1f6so2181790f8f.0 for ; Tue, 29 Sep 2026 03:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1790676363; x=1791281163; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MPuRlti25Fuu3NRfeKW/Nl7M5gDTcAuzPve5dEthuXw=; b=B99OoG1sjwpsNIExhUSsPk5rt/KuSYlxeKgYVRIOTHTbcgkOpb1nWwn6wsMwH0Oz8V o/7lLEIqgfC0iAVSH8XgRvUTFAllJ+r+394YKMpn041IesDXWJrw6CJekFTQuY9e4wfl F65Zg8W1xWrdtMIrVXUVPlSXjlgnCUSAoYtze6gZFbf4tM4Ysd+21NvuC+sYJnIAaqaW qwdUHu1fx71eZKol6umL4LydGHyiPPNvVtw37MX5+07gZogfsrjAflmYZkQ9a1a50bq3 Ei6JmnNBRYBXnZU/5o1zEv4QyxdS7qcKrMLOeSY58RgC4rETnJW/KghHyeJ+70MB+Jml ZfnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790676363; x=1791281163; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MPuRlti25Fuu3NRfeKW/Nl7M5gDTcAuzPve5dEthuXw=; b=QcMgecbr/XyGWy9y19RqP981HsY1CPLonGxR7DsBZaM36c7ouYfKEhIC92ZPLYwcMJ DfaiMBCYG2AhtFJOuepnYf7RcH4fVwBOvt01eJ11e/CfjswW5Ymidl2bCZrAoDM4c9VM z4hb9ot6pT0CVU8H5VvUdiM0kSDSMZOU10yHGBUvlGxR8e5mss01zz+pKE7UuLAMRMXd KeQbU69YIBfUqDQmKmYLt/fs5HQmD/VZKu8e/Vn3T3AW9LIA/gnmL2qkXGJQI5c8mH3s UdthNGM3mW9qNihVq6XEPKNUXpBfeZJotiJsK3O3sXoZJA6MgPh6mGYK69aPOMKDs3nw urMA== X-Forwarded-Encrypted: i=1; AKwUvBzVGFE7iaIBeAIWMPRJRQroGegCB483bK9lvHHnyvXd6dV1kKC8+WeqsQS/H6eioxVTBm0AH+lBGw==@vger.kernel.org X-Gm-Message-State: AFq9FYKbFcQCg5s/5/ICily/dP/baKjJTbuHFlPjCTSBTYbMC5NtSdHq JmIX55t2mAV1LiOfFpq3kzJ/XTlOD2uaNS1BJ5w8d/HVaP2MQB7D2whHRq6GX7VIOes= X-Gm-Gg: AYBFou3d3yypA3+UJ9opnMTSGCrkBZ1tpw+zn2e7/gPHo5g4CN/miv3mN9Pwpn8ba+s YES30M2S6C5/wpH6lursm9u+BNhyOcE+yo5/j81siQsPVh3jZvifIM/IJXKraohv/SNgRBh8L8R 0ntpItBRMtHg5B3wT1ZgUA/XF+ynI69R3/SAUjJ7SXLSQC+3wTaNwOsP/wYZkqV6k1X8PL1aSYK Fchrs8EhPP6BVM4oEqp8JZeKl/yM61wGoq01ob4udDb56JnI9DPOfMe2zFzkK94T0hX5i0ipXw7 rCLKnjX/di2kfRAGu7vrI1sHpKIyYi2C786P0eV3YGH72SQ4e+MetaPKeIUfEVgxHS1lIKduoLi v6HNKhbzfQL4OiVLBoVskTdHhbZfDHAvRkZ00iVBeyL6sBB3s3mZYvfoixNAN11W0LkxbHyPwNc VsJS5ulEWMlwvvKlOElwrPFpCMqGKBdVP/081jfpRdBP2Qi0F2nCxDLAJir1ljJZgUvKD9KCKzl WmhQVfGqo9nrhne X-Received: by 2002:a05:6000:2504:b0:485:ac3b:4a79 with SMTP id ffacd0b85a97d-488716a1af1mr29004379f8f.43.1790676363094; Tue, 29 Sep 2026 03:06:03 -0700 (PDT) Received: from alchark-surface.localdomain ([5.194.93.183]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48af502f79dsm2954995f8f.6.2026.09.29.03.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 03:06:02 -0700 (PDT) From: Alexey Charkov Date: Tue, 29 Sep 2026 14:05:47 +0400 Subject: [PATCH 2/4] regulator: of: state who owns the array from of_regulator_bulk_get_all() Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260929-regulator-get-all-v1-2-e887c66a47f1@flipper.net> References: <20260929-regulator-get-all-v1-0-e887c66a47f1@flipper.net> In-Reply-To: <20260929-regulator-get-all-v1-0-e887c66a47f1@flipper.net> To: Liam Girdwood , Mark Brown , Corentin Labbe , Manivannan Sadhasivam , Bartosz Golaszewski , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= Cc: linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bartosz Golaszewski , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1204; i=alchark@flipper.net; h=from:subject:message-id; bh=qOkoB1UvmuC4YZqe5Fz1zEEcDa7BiDDxjJDSjZCF8fI=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWTt7m1Z9Zv1RV2w79x3f+tfB33/dH7WkgfOOjL+v5pWb /dpfafr1DGRhUGMi8FSTJFl7rcltlON+Gbt8vD4CjOHlQlkiLRIAwMQsDDw5SbmlRrpGOmZahvq GRrpGOsYMXBxCsBUt11i+M1W7xUyq1a993NijNvBFa4Pz3dnSzZuP/B/Xf6G7HzVgNOMDBPNz+0 4vmpjcfa2gqLJ/yetzvwd4vzok/rE+GtPTuQGPGQFAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 of_regulator_bulk_get_all() allocates the consumer array and hands it to the caller, but never said so. Its own error path frees the array, while regulator_bulk_free() only puts the regulators, so both callers release the regulators and leak the array. Spell the contract out in the kerneldoc. Signed-off-by: Alexey Charkov --- drivers/regulator/of_regulator.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 785b7a11dfc6..09e26febfc83 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -929,6 +929,11 @@ static int is_supply_name(const char *name) * before returning to the caller, and @consumers will not be * changed. * + * On success the array is allocated here and handed to the caller, which + * owns it from then on: release the regulators with regulator_bulk_free() + * and free the array itself with kfree(). The supply names live in the + * same allocation, so they are gone once the array is freed. + * * Return: Number of regulators on success, or a negative error number * on failure. */ -- 2.55.0