From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF4A343B3CE for ; Tue, 6 Oct 2026 12:59:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791291548; cv=none; b=IujhKtklVCH5TX8EHrAipJW1RP7+Cr7uzOhoDAAWPk5TB2pV/K6wHrr4pBBO+t1ruGSU8bvma0hmM7GRzuh9nfd8+Ub4u9vDKhVKISW6JL/Ct3dCNIPk/FJE1Kd4o8Tq8jnrtM2yqYD4yfA/FQW2nU9DCcXFwNfrJriAA6aak+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791291548; c=relaxed/simple; bh=MgWAwea1MBQjQ6iZeCZdEffwq4LQ4ofw/92P0MY8PNY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gw2fAATHGcaAIxdinJS3/xHyLm6wObcXrqA471J1x/SkNlQ46PahyAQhLzlzZT29Dz1K/8m1RWojLXyyZod862u6L2trwjTcIRU9n+y/kpJxBOIOZyJ5700Mg2FD1gM+EPQ/p/wF1TsE9aLitWmLad0HdeK21MJPbw4Z7YAGqnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LwsW6yY0; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LwsW6yY0" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-ccce967aa8dso1031109a12.1 for ; Tue, 06 Oct 2026 05:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791291546; x=1791896346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=C2xk8Z03Jvlehme5HkwczAWmfFVokFO0rBq6AUapVGQ=; b=LwsW6yY0Q+cRi1IoJuWWyymVTmHup7hn02Q37Aa8feaogXhwcPK4muPu1sOaKbfGMH dHS3dFK4LBjWPnFctVRvPkab1Lv1ePGLsg9gLIcDoXBrGEJ2Hz+2XujnANdhrkmeO9L1 vRRhNz+6XjLuzkgINbf5IW4Loqc/84zByNrqFNhwQ93WNYXORkRFMCuczuVVuR+PsI2L 7Q+hJ6xbSROqwAZk4Qst3kEu2jRQNUZUJv60NcKl7/FI/oPiSPVC4VEqwaNZSytu7ckd 1vgnsTj6q4JN1bj7omz7Qg5XWKe0SW8eWBOOc1VdBpYM7vh/863LVqS7cAv80pleBMTO Fgfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791291546; x=1791896346; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C2xk8Z03Jvlehme5HkwczAWmfFVokFO0rBq6AUapVGQ=; b=EvQqkjKG/rpUkES/TEyJGA6sYsGprtI73HfX0AbLzvnRBlnf0cQpPZOhMUDX/QyOzg 6GayXwOxKPe/877pVapk9L8pd/rDP/cjmWq8NaQDc9Bl4LRwo15cFBmk9jZRW01US6Ni ibP15HqbbnHoFils55w7hl1tT4CE+uw6MjVYG59UOmLZDdwAboesuOI4fvZVE0Z1Lexf Jr/ZTR4YNlNXvETcxAEPef49QL9LCORm+WLOxy3W0eD7RK6CbHIYPp0s1J4d/abTAnhN RdxB6lrD8b8Z9Tm7PHE628042DpdhStzLc6eQeYaAoGDeCu0gN6R2AMD4P1DkmwkJ+2/ Sbvw== X-Forwarded-Encrypted: i=1; AKwUvByE3H4MYt+59Ipwr+19K8CGpKe3gO53IaKb25wQtH2amMdYJY1waYOqQhm31k3H9C0hk+p3ImXBNw==@vger.kernel.org X-Gm-Message-State: AFuF++mbK8e5vkKgoEe59cwom+OmQBm4CnqRIJwjnjy9y2vI1ebEJ0Oi fwE6gvWZ+bU0EWLSgJJudHxBHDhiZ+9WGWoDLfU8Wp1VBzoUz+6UUXVLAMlwLX6fScVyAA== X-Gm-Gg: AYBFou3XSZl+FqD6OQbxBnBaHUlQZ4r5wCPJjWQ7eb1xFz7/ThFr3TNz4IekxgBWlsZ l+NZyGbpZsaQjZSmC7NnoD162xZ+8Ijod3AUQ4h92VktzgnZEJuc0WptVB/ymCLQiNU8MpHWcKL Ojy0gjgA6AzPZAkPW8RIDCgmAJnjiI7U3oEJMWMgdpTq824FOB5D64DGFEeRsVyW8NepvqvmLdE 324BkzC1YDfFKUMcnlnZN0gb0H7069Gg11HJAxu9nI92d77fHScd8NfsmYT2qqTbPI0DGVg6xfT laBqIg1f7i92Y4HFOHbMSQF4f9SclhaDsUg026zLHcL52GlISFRWwrZZ9+7+qQNHQo8eD6B4Db0 o1KomntShrvYoWIV9ZhwAMonnNJHUrjzrpbPQ8C7jKyONufFC/4A8djXF6d+Med3H9wgUsu9WrX KGuPir3vk8oYgZ0jMq/z+s7iiFhjfIBK1LnGeKP+Y4bnuggI2TZbVnl9Fb6KPmyZsH4XcUOzOsC lMRhQWSkvq4rehu X-Received: by 2002:a05:6a21:d8c:b0:3e0:c3f8:4821 with SMTP id adf61e73a8af0-3e124890dbamr1163921637.41.1791291546091; Tue, 06 Oct 2026 05:59:06 -0700 (PDT) Received: from LAPTOP-450UDG4J ([2401:4900:900c:ec20:d139:f8fd:7043:7eb2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cce6d334de5sm2415225a12.11.2026.10.06.05.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 05:59:05 -0700 (PDT) From: Yogesh Gaur To: "Rafael J . Wysocki" Cc: Pavel Machek , Len Brown , David Hildenbrand , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Yogesh Gaur , syzbot+609c80047e3e808b465c@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: [PATCH] PM: hibernate: skip offline memory in mark_free_pages() Date: Tue, 6 Oct 2026 18:28:49 +0530 Message-ID: <20261006125849.1998-1-yogeshgaur.83@gmail.com> X-Mailer: git-send-email 2.55.0.windows.5 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mark_free_pages() walks every valid PFN of a zone and calls page_zone() on its struct page. A PFN in an offlined memory block is still valid, but its memmap is no longer initialised: offlining poisons it. With CONFIG_DEBUG_VM that is caught on the first such page: page:ffffea0005400000 is uninitialized and poisoned page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) kernel BUG at ./include/linux/mm.h:2402! RIP: 0010:mark_free_pages+0x49a/0x4b0 kernel/power/snapshot.c:1266 count_data_pages kernel/power/snapshot.c:1417 [inline] hibernate_preallocate_memory+0x14f/0x750 kernel/power/snapshot.c:1859 hibernation_snapshot+0xd5/0x3d0 kernel/power/hibernate.c:416 hibernate+0x28f/0x680 kernel/power/hibernate.c:813 syzbot's reproducer offlines memory42 and then writes "disk" to /sys/power/state; that page is the first one of memory42. Without CONFIG_DEBUG_VM the walk reads stale page flags instead. saveable_page() and saveable_highmem_page() already use pfn_to_online_page() for this since commit 5b56db37218e ("PM/Hibernate: use pfn_to_online_page()"). Do the same here. Offline pages are never on a free list, so the second loop in this function does not need it. Fixes: d33695b16a9f ("mm/memory_hotplug: poison memmap in remove_pfn_range_from_zone()") Reported-by: syzbot+609c80047e3e808b465c@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Yogesh Gaur --- Built with W=1 only; not runtime-tested. kernel/power/snapshot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index b209712cb2c3..0cd8f05c1395 100644 --- a/kernel/power/snapshot.c +++ b/kernel/power/snapshot.c @@ -1256,14 +1256,14 @@ static void mark_free_pages(struct zone *zone) max_zone_pfn = zone_end_pfn(zone); for_each_valid_pfn(pfn, zone->zone_start_pfn, max_zone_pfn) { - page = pfn_to_page(pfn); - if (!--page_count) { touch_nmi_watchdog(); page_count = WD_PAGE_COUNT; } - if (page_zone(page) != zone) + /* the memmap of offline memory is not initialised */ + page = pfn_to_online_page(pfn); + if (!page || page_zone(page) != zone) continue; if (!swsusp_page_is_forbidden(page)) -- 2.55.0.windows.5