From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] x86: use cpufreq_quick_get() for /proc/cpuinfo "cpu MHz" again Date: Wed, 15 Nov 2017 01:30:37 +0100 Message-ID: <2067351.8xeh6jAbVr@aspire.rjw.lan> References: <20171109103814.70688-1-chao.wang@ucloud.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from cloudserver094114.home.net.pl ([79.96.170.134]:48821 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbdKOAat (ORCPT ); Tue, 14 Nov 2017 19:30:49 -0500 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Linus Torvalds Cc: Thomas Gleixner , WANG Chao , Linux Kernel Mailing List , Ingo Molnar , "H. Peter Anvin" , Vikas Shivappa , Kate Stewart , Len Brown , Greg Kroah-Hartman , Philippe Ombredanne , Mathias Krause , the arch/x86 maintainers , Linux PM , "Rafael J. Wysocki" On Wednesday, November 15, 2017 1:06:12 AM CET Linus Torvalds wrote: > On Tue, Nov 14, 2017 at 4:04 PM, Linus Torvalds > wrote: > > On Tue, Nov 14, 2017 at 3:53 PM, Thomas Gleixner wrote: > >> Current head + Raphaels patch: > >> > >> real 0m0.029s > >> user 0m0.000s > >> sys 0m0.010s > >> > >> So that patch is actually slower. > > > > Oh it definitely is expected to be slower, because it does the IPI to > > all the cores and actually gets their frequency right. > > > > It was the old one that we had to revert (because it did so > > sequentially) that was really bad, and took something like 2+ seconds > > on Ingo's 160-core thing, iirc. > > Looked it up. Ingo's machine "only" had 120 cores, and he said > > fomalhaut:~> time cat /proc/cpuinfo >/dev/null > real 0m2.689s > > for the bad serial case, so yeah, it looks "a bit" better than it was ;) OK, so may I queue it up? I don't think I can get that to work substantially faster anyway ... Thanks, Rafael