From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Date: Thu, 21 Jul 2016 10:58:29 -0400 (EDT) Message-ID: <2117164955.9476317.1469113109470.JavaMail.zimbra@redhat.com> References: <1468928997-20431-1-git-send-email-pbonzini@redhat.com> <1617795.yheICcaOFs@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mx4-phx2.redhat.com ([209.132.183.25]:47879 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753113AbcGUO67 (ORCPT ); Thu, 21 Jul 2016 10:58:59 -0400 In-Reply-To: <1617795.yheICcaOFs@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, Thomas Renninger , Peter Zijlstra , linux-pm@vger.kernel.org, Jacob Pan , Andy Lutomirski ----- Original Message ----- > From: "Rafael J. Wysocki" > To: "Paolo Bonzini" > Cc: linux-kernel@vger.kernel.org, "Thomas Renninger" , "Peter Zijlstra" , > linux-pm@vger.kernel.org, "Jacob Pan" , "Andy Lutomirski" > Sent: Thursday, July 21, 2016 3:19:28 PM > Subject: Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM > > On Tuesday, July 19, 2016 01:49:57 PM Paolo Bonzini wrote: > > People complain about the driver saying there's no valid RAPL domains > > in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO > > if running on a hypervisor, since it is basically stating the obvious. > > > > Suggested-by: Peter Zijlstra > > Cc: Jacob Pan > > Cc: Andy Lutomirski > > Signed-off-by: Paolo Bonzini > > --- > > First sent out about a year ago. :) > > > > drivers/powercap/intel_rapl.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c > > index b2766b867b0e..0a0b09910116 100644 > > --- a/drivers/powercap/intel_rapl.c > > +++ b/drivers/powercap/intel_rapl.c > > @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package > > *rp, int cpu) > > } > > rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX); > > if (!rp->nr_domains) { > > - pr_err("no valid rapl domains found in package %d\n", rp->id); > > + printk("%sNo valid RAPL domains found in package %d\n", > > + boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR, > > + rp->id); > > But we print that message with pr_debug() now (as in linux-next). > > Do you still want to do anything about that? Oops, then I guess what is in linux-next is okay. Thanks, Paolo