From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v4] cpufreq: schedutil: rate limits for SCHED_DEADLINE Date: Wed, 14 Mar 2018 12:20:38 +0100 Message-ID: <2122625.mgU2W7rFO1@aspire.rjw.lan> References: <1520937340-2755-1-git-send-email-claudio@evidence.eu.com> <20180313111506.GC15832@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Joel Fernandes , Viresh Kumar , Claudio Scordino Cc: Peter Zijlstra , Ingo Molnar , "Rafael J . Wysocki" , Patrick Bellasi , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Vincent Guittot , Todd Kjos , Linux PM , LKML List-Id: linux-pm@vger.kernel.org On Wednesday, March 14, 2018 2:27:53 AM CET Joel Fernandes wrote: > On Tue, Mar 13, 2018 at 4:15 AM, Viresh Kumar wrote: > > On 13-03-18, 11:35, Claudio Scordino wrote: > >> When the SCHED_DEADLINE scheduling class increases the CPU utilization, > >> we should not wait for the rate limit, otherwise we may miss some > >> deadline. > >> > >> Tests using rt-app on Exynos5422 with up to 10 SCHED_DEADLINE tasks have > >> shown reductions of even 10% of deadline misses with a negligible > >> increase of energy consumption (measured through Baylibre Cape). > >> > >> Signed-off-by: Claudio Scordino > >> Acked-by: Viresh Kumar > >> Reviewed-by: Rafael J. Wysocki > >> CC: Rafael J. Wysocki > >> CC: Viresh Kumar > >> CC: Patrick Bellasi > >> CC: Dietmar Eggemann > >> CC: Morten Rasmussen > >> CC: Juri Lelli > >> CC: Vincent Guittot > >> CC: Todd Kjos > >> CC: Joel Fernandes > >> CC: linux-pm@vger.kernel.org > >> CC: linux-kernel@vger.kernel.org > >> --- > >> Changes from v3: > >> - Specific routine renamed as ignore_dl_rate_limit() > > > > LGTM. Thanks. > > Nice! Thanks. OK, the patch doesn't seem to depend on anything in -tip, so I'm going to apply it. Thanks!