Re: [PATCH 10/18] thermal: exynos: move IRQs clearing to exynos_tmu_initialize()

Eduardo Valentin
2018-05-06T23:27:04Z

Hey,

On Thu, Apr 26, 2018 at 01:51:25PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Move ->tmu_clear_irqs call from ->tmu_initialize method to
> exynos_tmu_initialize().
>
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 1664d37..82484c5 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -368,8 +368,10 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
> status = readb(data->base + EXYNOS_TMU_REG_STATUS);
> if (!status)
> ret = -EBUSY;
> - else
> + else {
> data->tmu_initialize(pdev);
> + data->tmu_clear_irqs(data);
> + }

You should actually enclose the if statement also in curls here:
if (!status) {
ret = -EBUSY;
} else {
data->tmu_initialize(pdev);
data->tmu_clear_irqs(data);
}

Fixing myself, but next time pay attention to kernel coding style
CHECK: Unbalanced braces around else statement
#35: FILE: drivers/thermal/samsung/exynos_tmu.c:371:
+ else {

total: 0 errors, 0 warnings, 1 checks, 43 lines checked

>