From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-pm@vger.kernel.org, Viresh Kumar <viresh.kumar@linaro.org>,
Kevin Hilman <khilman@kernel.org>
Subject: Re: [PATCH] PM / Domains: Align in-parameter names for some genpd functions
Date: Mon, 26 Aug 2019 11:12:26 +0200 [thread overview]
Message-ID: <21786600.6syGFu3F7C@kreacher> (raw)
In-Reply-To: <20190716094320.20091-1-ulf.hansson@linaro.org>
On Tuesday, July 16, 2019 11:43:20 AM CEST Ulf Hansson wrote:
> Align in-parameter names for the declarations of pm_genpd_add|
> remove_subdomain() and of_genpd_add_subdomain() according to their
> implementations, as to improve consistency.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> include/linux/pm_domain.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index 91d9bf497071..baf02ff91a31 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -197,9 +197,9 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev)
> int pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev);
> int pm_genpd_remove_device(struct device *dev);
> int pm_genpd_add_subdomain(struct generic_pm_domain *genpd,
> - struct generic_pm_domain *new_subdomain);
> + struct generic_pm_domain *subdomain);
> int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,
> - struct generic_pm_domain *target);
> + struct generic_pm_domain *subdomain);
> int pm_genpd_init(struct generic_pm_domain *genpd,
> struct dev_power_governor *gov, bool is_off);
> int pm_genpd_remove(struct generic_pm_domain *genpd);
> @@ -226,12 +226,12 @@ static inline int pm_genpd_remove_device(struct device *dev)
> return -ENOSYS;
> }
> static inline int pm_genpd_add_subdomain(struct generic_pm_domain *genpd,
> - struct generic_pm_domain *new_sd)
> + struct generic_pm_domain *subdomain)
> {
> return -ENOSYS;
> }
> static inline int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,
> - struct generic_pm_domain *target)
> + struct generic_pm_domain *subdomain)
> {
> return -ENOSYS;
> }
> @@ -282,8 +282,8 @@ int of_genpd_add_provider_onecell(struct device_node *np,
> struct genpd_onecell_data *data);
> void of_genpd_del_provider(struct device_node *np);
> int of_genpd_add_device(struct of_phandle_args *args, struct device *dev);
> -int of_genpd_add_subdomain(struct of_phandle_args *parent,
> - struct of_phandle_args *new_subdomain);
> +int of_genpd_add_subdomain(struct of_phandle_args *parent_spec,
> + struct of_phandle_args *subdomain_spec);
> struct generic_pm_domain *of_genpd_remove_last(struct device_node *np);
> int of_genpd_parse_idle_states(struct device_node *dn,
> struct genpd_power_state **states, int *n);
> @@ -316,8 +316,8 @@ static inline int of_genpd_add_device(struct of_phandle_args *args,
> return -ENODEV;
> }
>
> -static inline int of_genpd_add_subdomain(struct of_phandle_args *parent,
> - struct of_phandle_args *new_subdomain)
> +static inline int of_genpd_add_subdomain(struct of_phandle_args *parent_spec,
> + struct of_phandle_args *subdomain_spec)
> {
> return -ENODEV;
> }
>
Applied, thanks!
prev parent reply other threads:[~2019-08-26 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 9:43 [PATCH] PM / Domains: Align in-parameter names for some genpd functions Ulf Hansson
2019-08-26 9:12 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21786600.6syGFu3F7C@kreacher \
--to=rjw@rjwysocki.net \
--cc=khilman@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox