From: Len Brown <lenb@kernel.org>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: [PATCH 33/44] tools/power turbostat: fix zero IRQ count shown in one-shot command mode
Date: Wed, 1 Mar 2017 00:27:37 -0500 [thread overview]
Message-ID: <218f0e8d5c388767be9c78fd2c5bc0a6f416d6d0.1488345270.git.len.brown@intel.com> (raw)
In-Reply-To: <20170301052748.27810-1-lenb@kernel.org>
In-Reply-To: <678a3bd1b3de6d2ebf604e7d708bc8150bb667e9.1488345270.git.len.brown@intel.com>
From: Len Brown <len.brown@intel.com>
The IRQ column has been working for periodic mode,
but not in one-shot command mode, it shows only 0.
until now.
Signed-off-by: Len Brown <len.brown@intel.com>
---
tools/power/x86/turbostat/turbostat.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 8c965bb2f461..48b540a2fe81 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -619,9 +619,9 @@ int dump_counters(struct thread_data *t, struct core_data *c,
outp += sprintf(outp, "c1: %016llX\n", t->c1);
if (DO_BIC(BIC_IRQ))
- outp += sprintf(outp, "IRQ: %08X\n", t->irq_count);
+ outp += sprintf(outp, "IRQ: %d\n", t->irq_count);
if (DO_BIC(BIC_SMI))
- outp += sprintf(outp, "SMI: %08X\n", t->smi_count);
+ outp += sprintf(outp, "SMI: %d\n", t->smi_count);
for (i = 0, mp = sys.tp; mp; i++, mp = mp->next) {
outp += sprintf(outp, "tADDED [%d] msr0x%x: %08llX\n",
@@ -2410,8 +2410,9 @@ int snapshot_gfx_mhz(void)
*/
int snapshot_proc_sysfs_files(void)
{
- if (snapshot_proc_interrupts())
- return 1;
+ if (DO_BIC(BIC_IRQ))
+ if (snapshot_proc_interrupts())
+ return 1;
if (DO_BIC(BIC_GFX_rc6))
snapshot_gfx_rc6_ms();
@@ -4391,6 +4392,7 @@ int fork_it(char **argv)
pid_t child_pid;
int status;
+ snapshot_proc_sysfs_files();
status = for_all_cpus(get_counters, EVEN_COUNTERS);
if (status)
exit(status);
@@ -4417,6 +4419,7 @@ int fork_it(char **argv)
* n.b. fork_it() does not check for errors from for_all_cpus()
* because re-starting is problematic when forking
*/
+ snapshot_proc_sysfs_files();
for_all_cpus(get_counters, ODD_COUNTERS);
gettimeofday(&tv_odd, (struct timezone *)NULL);
timersub(&tv_odd, &tv_even, &tv_delta);
@@ -4438,6 +4441,7 @@ int get_and_dump_counters(void)
{
int status;
+ snapshot_proc_sysfs_files();
status = for_all_cpus(get_counters, ODD_COUNTERS);
if (status)
return status;
--
2.11.0.161.g6610af872
next prev parent reply other threads:[~2017-03-01 7:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 5:27 [GIT PULL] turbostat 17.02.24 Len Brown
2017-03-01 5:27 ` [PATCH 01/44] tools/power turbostat: fix bugs in --add option Len Brown
2017-03-01 5:27 ` [PATCH 02/44] tools/power turbostat: Add --show and --hide parameters Len Brown
2017-03-01 5:27 ` [PATCH 03/44] tools/power turbostat: BYT does not have MSR_MISC_PWR_MGMT Len Brown
2017-03-01 5:27 ` [PATCH 04/44] tools/power turbostat: decode Baytrail CC6 and MC6 demotion configuration Len Brown
2017-03-01 5:27 ` [PATCH 05/44] tools/power turbostat: Baytrail: remove debug line in quiet mode Len Brown
2017-03-01 5:27 ` [PATCH 06/44] tools/power turbostat: update MSR_PKG_CST_CONFIG_CONTROL decoding Len Brown
2017-03-01 5:27 ` [PATCH 07/44] x86: msr-index.h: Define MSR_PKG_CST_CONFIG_CONTROL Len Brown
2017-03-01 5:27 ` [PATCH 08/44] intel_idle: use new name for MSR_PKG_CST_CONFIG_CONTROL Len Brown
2017-03-01 5:27 ` [PATCH 09/44] tools/power turbostat: " Len Brown
2017-03-01 5:27 ` [PATCH 10/44] x86: msr-index.h: Remove unused MSR_NHM_SNB_PKG_CST_CFG_CTL Len Brown
2017-03-01 5:27 ` [PATCH 11/44] tools/power turbostat: Baytrail c-state support Len Brown
2017-03-01 5:27 ` [PATCH 12/44] tools/power turbostat: add precision to --debug frequency output Len Brown
2017-03-01 5:27 ` [PATCH 13/44] tools/power turbostat: further decode MSR_IA32_MISC_ENABLE Len Brown
2017-03-01 5:27 ` [PATCH 14/44] x86 msr-index.h: Define Atom specific core ratio MSR locations Len Brown
2017-03-01 5:27 ` [PATCH 15/44] intel_pstate: use MSR_ATOM_RATIOS definitions from msr-index.h Len Brown
2017-03-01 5:27 ` [PATCH 16/44] tools/power turbostat: dump Atom P-states correctly Len Brown
2017-03-01 5:27 ` [PATCH 17/44] tools/power turbostat: decode CPUID(6).TURBO Len Brown
2017-03-01 5:27 ` [PATCH 18/44] x86 msr_index.h: Define MSR_MISC_FEATURE_CONTROL Len Brown
2017-03-01 5:27 ` [PATCH 19/44] tools/power turbostat: decode MSR_MISC_FEATURE_CONTROL Len Brown
2017-03-01 5:27 ` [PATCH 20/44] tools/power turbostat: show all columns, independent of --debug Len Brown
2017-03-01 5:27 ` [PATCH 21/44] tools/power turbostat: print system config, unless --quiet Len Brown
2017-03-01 5:27 ` [PATCH 22/44] tools/power turbostat: use tsc_tweak everwhere it is needed Len Brown
2017-03-01 5:27 ` [PATCH 23/44] tools/power turbostat: bug fixes to --add, --show/--hide features Len Brown
2017-03-01 5:27 ` [PATCH 24/44] x86: intel-family.h: Add GEMINI_LAKE SOC Len Brown
2017-03-01 23:48 ` Andy Shevchenko
2017-03-01 5:27 ` [PATCH 25/44] tools/power turbostat: initial Gemini Lake SOC support Len Brown
2017-03-01 5:27 ` [PATCH 26/44] tools/power turbostat: Denverton: use HW CC1 counter, skip C3, C7 Len Brown
2017-03-01 5:27 ` [PATCH 27/44] tools/power turbostat: skip unused counters on SKX Len Brown
2017-03-01 5:27 ` [PATCH 28/44] tools/power turbostat: fix decoding for GLM, DNV, SKX turbo-ratio limits Len Brown
2017-03-01 5:27 ` [PATCH 29/44] tools/power turbostat: skip unused counters on BDX Len Brown
2017-03-01 5:27 ` [PATCH 30/44] tools/power turbostat: extend --add option to accept /sys path Len Brown
2017-03-01 5:27 ` [PATCH 31/44] tools/power turbostat: print sysfs C-state stats Len Brown
2017-03-01 5:27 ` [PATCH 32/44] tools/power turbostat: add --cpu parameter Len Brown
2017-03-01 5:27 ` Len Brown [this message]
2017-03-01 5:27 ` [PATCH 34/44] tools/power turbostat: Add --list option to show available header names Len Brown
2017-03-01 5:27 ` [PATCH 35/44] tools/power turbostat: use wide columns to display large numbers Len Brown
2017-03-01 5:27 ` [PATCH 36/44] tools/power turbostat: update --list feature Len Brown
2017-03-01 5:27 ` [PATCH 37/44] tools/power turbostat: turbostat.8 update Len Brown
2017-03-01 5:27 ` [PATCH 38/44] tools/power turbostat: move --Package and --processor into the --cpu option Len Brown
2017-03-01 5:27 ` [PATCH 39/44] tools/power turbostat: support "--hide C1" etc Len Brown
2017-03-01 5:27 ` [PATCH 40/44] tools/power turbostat: show package number, even without --debug Len Brown
2017-03-01 5:27 ` [PATCH 41/44] tools/power turbostat: dump p-state software config Len Brown
2017-03-01 5:27 ` [PATCH 42/44] tools/power turbostat: show error on exec Len Brown
2017-03-01 5:27 ` [PATCH 43/44] tools/power turbostat: bugfix: --add u32 was printed as u64 Len Brown
2017-03-01 5:27 ` [PATCH 44/44] tools/power turbostat: version 17.02.24 Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=218f0e8d5c388767be9c78fd2c5bc0a6f416d6d0.1488345270.git.len.brown@intel.com \
--to=lenb@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).